Issue 557720043: Documentation: Add dependency notation.texi -> internals.texi

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 557720043: Documentation: Add dependency notation.texi -> internals.texi (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
3 years, 12 months ago by hahnjo

Modified:
3 years, 11 months ago

Reviewers:
Valentin Villenave, lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Documentation: Add dependency notation.texi -> internals.texi notation.tely includes, via notation/notation-appendices.itely, many generated files (like markup-commands.tely). These are the result of processing ly/generate-documentation.ly for internals.texi

Patch Set 1 #

Total comments: 1

Created: 3 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -10 lines)			Patch
	M	Documentation/GNUmakefile	View		1 chunk	+7 lines, -10 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

hahnjo

If nobody disagrees, I'd like to push this rather sooner than later because James is ...

3 years, 12 months ago (2020-04-21 07:29:27 UTC) #1

Valentin Villenave

On 2020/04/21 07:29:27, hahnjo wrote: > If nobody disagrees, I'd like to push this rather ...

3 years, 12 months ago (2020-04-21 08:47:13 UTC) #2

lemzwerg

LGTM https://codereview.appspot.com/557720043/diff/581940043/Documentation/GNUmakefile File Documentation/GNUmakefile (right): https://codereview.appspot.com/557720043/diff/581940043/Documentation/GNUmakefile#newcode304 Documentation/GNUmakefile:304: $(outdir)/contributor.texi: $(outdir)/ly-grammar.txt Please add an empty line here.

3 years, 12 months ago (2020-04-21 08:48:54 UTC) #3

hahnjo

3 years, 12 months ago (2020-04-21 09:07:56 UTC) #4

On 2020/04/21 08:48:54, lemzwerg wrote:
> LGTM
> 
>
https://codereview.appspot.com/557720043/diff/581940043/Documentation/GNUmake...
> File Documentation/GNUmakefile (right):
> 
>
https://codereview.appspot.com/557720043/diff/581940043/Documentation/GNUmake...
> Documentation/GNUmakefile:304: $(outdir)/contributor.texi:
> $(outdir)/ly-grammar.txt
> Please add an empty line here.

Done before pushing

commit 338f83af6e9014042cf7266e82e8cfa852e89ebb
Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
AuthorDate: Tue Apr 21 09:21:40 2020 +0200
Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
CommitDate: Tue Apr 21 11:04:55 2020 +0200

    Documentation: Add dependency notation.texi -> internals.texi
    
    notation.tely includes, via notation/notation-appendices.itely, many
    generated files (like markup-commands.tely). These are the result of
    processing ly/generate-documentation.ly for internals.texi

Expand All Messages | Collapse All Messages