Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(146)

Issue 5572049: Avoid correcting unknown identifiers to types where types aren't allowed.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by Kaelyn
Modified:
7 years, 9 months ago
Reviewers:
kyrtzidis
CC:
cfe-commits_cs.uiuc.edu
Visibility:
Public.

Description

Pass a typo correction callback object from ParseCastExpr to Sema::ActOnIdExpression to be a bit more selective about what kinds of corrections will be allowed for unknown identifiers.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -18 lines) Patch
M include/clang/Parse/Parser.h View 2 chunks +11 lines, -4 lines 0 comments Download
M include/clang/Sema/Sema.h View 1 chunk +2 lines, -1 line 0 comments Download
M lib/Parse/ParseExpr.cpp View 11 chunks +39 lines, -10 lines 0 comments Download
M lib/Parse/ParseExprCXX.cpp View 1 chunk +1 line, -1 line 0 comments Download
M lib/Sema/SemaExpr.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M test/SemaCXX/typo-correction.cpp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Kaelyn
7 years, 9 months ago (2012-01-23 20:45:59 UTC) #1
Kaelyn
Ping? I'd at least like someone more familiar with the parser to give this patch ...
7 years, 9 months ago (2012-01-25 18:49:23 UTC) #2
kyrtzidis_apple.com
7 years, 9 months ago (2012-01-25 20:02:29 UTC) #3
LGTM!

On Jan 25, 2012, at 10:49 AM, Kaelyn Uhrain wrote:

> Ping? I'd at least like someone more familiar with the parser to give this
patch a once-over before committing it.
> 
> Thanks,
> Kaelyn
> 
> On Mon, Jan 23, 2012 at 12:45 PM, <rikka@google.com> wrote:
> Reviewers: kyrtzidis_apple.com,
> 
> Description:
> Pass a typo correction callback object from ParseCastExpr to
> Sema::ActOnIdExpression to be a bit more selective about what kinds of
> corrections will be allowed for unknown identifiers.
> 
> Please review this at http://codereview.appspot.com/5572049/
> 
> Affected files:
>  M include/clang/Parse/Parser.h
>  M include/clang/Sema/Sema.h
>  M lib/Parse/ParseExpr.cpp
>  M lib/Parse/ParseExprCXX.cpp
>  M lib/Sema/SemaExpr.cpp
>  M test/SemaCXX/typo-correction.cpp
> 
> 
> 

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b