Issue 556950043: Issue 5541: treat CENTER in Side_position_interface::aligned_side

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 556950043: Issue 5541: treat CENTER in Side_position_interface::aligned_side (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 8 months ago by dak

Modified:
2 years, 4 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 5541: treat CENTER in Side_position_interface::aligned_side Previously this led to an assertion failure (and obscure behavior when assertions were disabled). This currently warns while doing a reasonable replacement: it is conceivable that the replacement is useful enough on its own, making it debatable whether a warning is wanted.

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	lily/side-position-interface.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download