Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(260)

Issue 5558056: code review 5558056: net: fix linux build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by mikio
Modified:
11 years ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

net: fix linux build

Patch Set 1 #

Patch Set 2 : diff -r b60bc9a6b439 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b60bc9a6b439 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 25879029ed5b https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 25879029ed5b https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 6 : diff -r cc1fb54d8263 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M src/pkg/net/unicast_test.go View 1 2 3 4 5 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 14
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years ago (2012-01-19 23:45:49 UTC) #1
bradfitz
Is that a fix or just silencing the test? On Thu, Jan 19, 2012 at ...
11 years ago (2012-01-19 23:47:26 UTC) #2
bradfitz
If it's a fix, it needs a comment inside that block, but pretty sad that ...
11 years ago (2012-01-19 23:48:02 UTC) #3
mikio
It's just a pray for silence. We need to have a look at the kernel ...
11 years ago (2012-01-20 01:22:36 UTC) #4
mikio
On Fri, Jan 20, 2012 at 10:22 AM, Mikio Hara <mikioh.mikioh@gmail.com> wrote: > We need ...
11 years ago (2012-01-20 01:59:07 UTC) #5
mikio
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years ago (2012-01-20 01:59:28 UTC) #6
bradfitz
Glad you found it! http://codereview.appspot.com/5558056/diff/7001/src/pkg/net/unicast_test.go File src/pkg/net/unicast_test.go (right): http://codereview.appspot.com/5558056/diff/7001/src/pkg/net/unicast_test.go#newcode17 src/pkg/net/unicast_test.go:17: l Listener why do you ...
11 years ago (2012-01-20 02:31:14 UTC) #7
mikio
On Fri, Jan 20, 2012 at 11:31 AM, <bradfitz@golang.org> wrote: > Glad you found it! ...
11 years ago (2012-01-20 02:46:54 UTC) #8
mikio
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years ago (2012-01-20 02:47:10 UTC) #9
bradfitz
LGTM Thanks! It's back to passing here. On Thu, Jan 19, 2012 at 6:47 PM, ...
11 years ago (2012-01-20 02:50:55 UTC) #10
bradfitz
Incidentally, this is interesting data for a mystery bug of mine, http://code.google.com/p/go/issues/detail?id=2581 I guess that's ...
11 years ago (2012-01-20 02:52:12 UTC) #11
bradfitz
*** Submitted as http://code.google.com/p/go/source/detail?r=566110b6be97 *** net: fix linux build R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/5558056 Committer: Brad ...
11 years ago (2012-01-20 02:56:29 UTC) #12
mikio
On Fri, Jan 20, 2012 at 11:52 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > Incidentally, this ...
11 years ago (2012-01-20 03:22:57 UTC) #13
bradfitz
11 years ago (2012-01-20 03:24:53 UTC) #14
On Thu, Jan 19, 2012 at 7:22 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:

> On Fri, Jan 20, 2012 at 11:52 AM, Brad Fitzpatrick <bradfitz@golang.org>
> wrote:
>
> > Incidentally, this is interesting data for a mystery bug of mine,
> >
> > http://code.google.com/p/go/issues/detail?id=2581
> >
> > I guess that's just how these operating systems differ.
>
> Recently I realized that that's a part of Go's fun even if
> I have to write a patch on a crush commuter train.
>

Glad you got the files uploaded before you hit the tunnel and lost
connectivity, all Mission Impossible-style. :-)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b