Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 554930043: Replace file() by open()

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 5 days ago by hahnjo
Modified:
2 weeks, 5 days ago
Reviewers:
carl.d.sorensen, Carl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Replace file() by open() Since some Python 2.x, the documentation recommends using open() for opening a file. The constructor file() cannot be used anymore in Python 3 while open() was available at least in Python 2.4.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M python/book_latex.py View 1 chunk +1 line, -1 line 0 comments Download
M python/book_snippets.py View 6 chunks +8 lines, -8 lines 0 comments Download
M scripts/build/pytt.py View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/lilypond-book.py View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 1
Carl
2 weeks, 5 days ago (2019-10-29 16:13:49 UTC) #1
LGTM, although I haven't tested it.

Thanks, for working on this!

Carl
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b