Issue 554930043: Replace file() by open()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 554930043: Replace file() by open() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 5 months ago by hahnjo

Modified:
4 years, 3 months ago

Reviewers:
carl.d.sorensen, Carl

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Replace file() by open() Since some Python 2.x, the documentation recommends using open() for opening a file. The constructor file() cannot be used anymore in Python 3 while open() was available at least in Python 2.4.

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -17 lines)			Patch
M	python/book_latex.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	python/book_snippets.py	View	6 chunks	+8 lines, -8 lines	0 comments	Download
M	scripts/build/pytt.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	scripts/lilypond-book.py	View	6 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Carl

4 years, 5 months ago (2019-10-29 16:13:49 UTC) #1

LGTM, although I haven't tested it.

Thanks, for working on this!

Carl

Expand All Messages | Collapse All Messages