Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(77)

Issue 554550043: Revert the changes of issue 4914 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by dak
Modified:
2 years, 4 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Revert the changes of issue 4914 The underlying premise was a mistake since an engraver at Score level cannot establish a connection to just the Voice context currently pertinent in iteration. This can only be done by an iterator. At the same time, the connection with particular grobs needs to be established by an engraver. A tenable solution would use dedicated synthetic stream events like the Override and Revert events and would put up a listener at engraver group level. This kind of super-invasive change to the event hierarchy does not make sense in the 2.20 release frame. The only sensible option at the current point of time is to restore the previous state requiring an instance of Output_property_engraver at every layer that should implement \applyOutput . Revert "Merge branch 'issue4914'" This reverts commit 0f3898aade7077c15adb2b457e6a5e1238939085, reversing changes made to 90fce106774e91373aba8308f39da486064f4cef.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M Documentation/ly-examples/orchestra.ly View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/engravers-one-by-one.ly View 2 chunks +3 lines, -0 lines 0 comments Download
M input/regression/spacing-to-empty-barline.ly View 2 chunks +2 lines, -1 line 0 comments Download
M lily/output-property-engraver.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M ly/engraver-init.ly View 7 chunks +7 lines, -0 lines 0 comments Download
M python/convertrules.py View 2 chunks +1 line, -5 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b