Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(665)

Unified Diff: lily/skyline.cc

Issue 554000043: Avoid using Skyline_pair::insert. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lily/skyline.cc
diff --git a/lily/skyline.cc b/lily/skyline.cc
index f04d53bd803067e3fcdbaf29e61c152e63e09f17..fa154c4e2720b15bae3a741f9436caf24bf3c1fd 100644
--- a/lily/skyline.cc
+++ b/lily/skyline.cc
@@ -504,28 +504,6 @@ Skyline::merge (Skyline const &other)
internal_merge_skyline (&other_bld, &my_bld, &buildings_);
}
-void
-Skyline::insert (Box const &b, Axis a)
-{
- if (std::isnan (b[other_axis (a)][LEFT])
- || std::isnan (b[other_axis (a)][RIGHT]))
- {
- programming_error ("insane box for skyline");
- return;
- }
-
- /* do the same filtering as in Skyline (vector<Box> const&, etc.) */
- if (b.is_empty (X_AXIS) || b.is_empty (Y_AXIS))
- return;
-
- vector<Building> my_bld = buildings_;
- buildings_.clear ();
-
- vector<Building> other_bld;
- single_skyline (Building (b, a, sky_), &other_bld);
- internal_merge_skyline (&other_bld, &my_bld, &buildings_);
-}
-
void
Skyline::raise (Real r)
{

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b