Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(164)

Issue 553760043: Add dynamic-interface to keepAliveInterfaces

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 2 days ago by jean
Modified:
1 week, 2 days ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add dynamic-interface to keepAliveInterfaces This will prevent \Remove[All]EmptyStaves from removing Dynamics contexts containing dynamics attached to spacer rests but no actual notes (the standard use case for a Dynamics context).

Patch Set 1 #

Patch Set 2 : Add dynamic-interface to keepAliveInterfaces #

Patch Set 3 : Add dynamic-interface to keepAliveInterfaces #

Patch Set 4 : Add dynamic-interface to keepAliveInterfaces #

Patch Set 5 : Add dynamic-interface to keepAliveInterfaces #

Patch Set 6 : Add dynamic-interface to keepAliveInterfaces #

Patch Set 7 : Add dynamic-interface to keepAliveInterfaces #

Patch Set 8 : Add dynamic-interface to keepAliveInterfaces #

Patch Set 9 : Add dynamic-interface to keepAliveInterfaces #

Total comments: 2

Patch Set 10 : Adress review comments on the documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M Documentation/notation/staff.itely View 1 2 3 4 5 6 7 8 9 3 chunks +34 lines, -6 lines 0 comments Download
M ly/engraver-init.ly View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22
jean
Add dynamic-interface to keepAliveInterfaces
2 weeks, 1 day ago (2020-03-25 21:51:14 UTC) #1
jean
Add dynamic-interface to keepAliveInterfaces
2 weeks, 1 day ago (2020-03-25 21:52:13 UTC) #2
jean
Add dynamic-interface to keepAliveInterfaces
2 weeks ago (2020-03-26 10:33:10 UTC) #3
jean
Add dynamic-interface to keepAliveInterfaces
2 weeks ago (2020-03-26 10:33:44 UTC) #4
jean
Add dynamic-interface to keepAliveInterfaces
2 weeks ago (2020-03-26 10:39:15 UTC) #5
jean
Add dynamic-interface to keepAliveInterfaces
2 weeks ago (2020-03-26 11:26:12 UTC) #6
jean
Add dynamic-interface to keepAliveInterfaces
2 weeks ago (2020-03-26 11:35:59 UTC) #7
dak
What I am worried about is a partitura that puts common dynamics on every staff, ...
2 weeks ago (2020-03-26 12:01:40 UTC) #8
jean
Add dynamic-interface to keepAliveInterfaces
2 weeks ago (2020-03-26 12:24:33 UTC) #9
lemzwerg
LGTM https://codereview.appspot.com/553760043/diff/565830044/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): https://codereview.appspot.com/553760043/diff/565830044/Documentation/notation/staff.itely#newcode801 Documentation/notation/staff.itely:801: rests, skips, or a combination of these elements. ...
2 weeks ago (2020-03-26 12:50:11 UTC) #10
wl_gnu.org
> What I am worried about is a partitura that puts common dynamics on > ...
2 weeks ago (2020-03-26 12:52:29 UTC) #11
Valentin Villenave
On 2020/03/26 12:52:29, wl_gnu.org wrote: > Never seen that, AFAIK. Can you provide a link ...
2 weeks ago (2020-03-26 16:31:17 UTC) #12
wl_gnu.org
>> Never seen that, AFAIK. Can you provide a link to such a score? > ...
2 weeks ago (2020-03-26 16:41:41 UTC) #13
jean
Adress review comments on the documentation
1 week, 6 days ago (2020-03-27 18:39:35 UTC) #14
jean
This is a relevant point, but I think Werner is right. You can put your ...
1 week, 6 days ago (2020-03-27 19:00:08 UTC) #15
Valentin Villenave
On 2020/03/27 19:00:08, jean wrote: > I can see no situation where the current value ...
1 week, 6 days ago (2020-03-27 23:08:23 UTC) #16
Dan Eble
Is the impact (if any) on existing scores important? (cases that we might not have ...
1 week, 6 days ago (2020-03-27 23:16:40 UTC) #17
Dan Eble
On 2020/03/27 23:16:40, Dan Eble wrote: > Is the impact (if any) on existing scores ...
1 week, 6 days ago (2020-03-27 23:29:56 UTC) #18
jean
On 2020/03/27 23:16:40, Dan Eble wrote: > Is the impact (if any) on existing scores ...
1 week, 2 days ago (2020-03-31 20:14:44 UTC) #19
jean
On 2020/03/31 20:14:44, jean wrote: > I'll update the documentation with this. Hum, while exploring ...
1 week, 2 days ago (2020-03-31 20:26:51 UTC) #20
Valentin Villenave
On 3/31/20, jean@abou-samra.fr <jean@abou-samra.fr> wrote: > By the way, why do we say \RemoveEmptyStaves instead ...
1 week, 2 days ago (2020-03-31 20:43:03 UTC) #21
Valentin Villenave
1 week, 2 days ago (2020-03-31 20:51:05 UTC) #22
On 3/31/20, jean@abou-samra.fr <jean@abou-samra.fr> wrote:
> I'll take a look at it, and try to write appropriate documentation (or
> find the authors and ask them to document it!). Setting the issue to
> needs_work.

I believe it was added by Joe Neeman in order to fix issue #442:
https://sourceforge.net/p/testlilyissues/issues/442/

You can’t say it’s undocumented, its documentation is just not meant
for regular users:
http://lilypond.org/doc/latest/Documentation/internals/keep_005falive_005ftog...
There are also several comments in the source code:
http://git.savannah.gnu.org/cgit/lilypond.git/tree/lily/keep-alive-together-e...

Cheers,
- V.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b