Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(903)

Issue 5530068: code review 5530068: exp/sql: close Rows on EOF (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by bradfitz
Modified:
9 years ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

exp/sql: close Rows on EOF Fixes issue 2624

Patch Set 1 #

Patch Set 2 : diff -r 678cff445e7b https://go.googlecode.com/hg #

Patch Set 3 : diff -r 678cff445e7b https://go.googlecode.com/hg #

Patch Set 4 : diff -r f2999ed409ce https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -11 lines) Patch
M src/pkg/exp/sql/fakedb_test.go View 1 1 chunk +17 lines, -8 lines 0 comments Download
M src/pkg/exp/sql/sql.go View 1 2 chunks +5 lines, -2 lines 0 comments Download
M src/pkg/exp/sql/sql_test.go View 1 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
9 years ago (2012-01-10 19:45:29 UTC) #1
rsc
LGTM
9 years ago (2012-01-10 19:47:52 UTC) #2
bradfitz
9 years ago (2012-01-10 20:51:31 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=80041d018d07 ***

exp/sql: close Rows on EOF

Fixes issue 2624

R=rsc
CC=golang-dev
http://codereview.appspot.com/5530068
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b