Add glib-2.0 and gobject-2.0 library dependency

Add glib-2.0 and gobject-2.0 library dependency

For a long time we relied on pango/pangoft2 to pull in
the glib and gobject libraries. That worked as long as
every distribution used a pangoft2.pc file that included
both libs in the 'Required:' line.

According to the pkg-config documentation that was
definitely wrong, and the problem was corrected  on
opensuse tumbleweed recently. As a consequence building
lilypond failed with a linker error as we use symbols
from both libs directly in our c++ source code.

Signed-off-by: Knut Petersen <knut_petersen@t-online.de>

[lemzwerg, 2019-06-04 05:40:35]

LGTM, with only small issues that don't deserve a new upload.  Since Knut
doesn't have time I can take care of the patch, fixing the minor issues.

https://codereview.appspot.com/552770043/diff/574790043/aclocal.m4
File aclocal.m4 (right):

https://codereview.appspot.com/552770043/diff/574790043/aclocal.m4#newcode1291
aclocal.m4:1291: save_CPPFLAGS="$CPPFLAGS"
we probably should replace tabs with spaces ...

https://codereview.appspot.com/552770043/diff/574790043/config.make.in
File config.make.in (right):

https://codereview.appspot.com/552770043/diff/574790043/config.make.in#newcode23
config.make.in:23: CONFIG_CFLAGS = @CFLAGS@ $(GLIB_CFLAGS)$(GUILE_CFLAGS)
$(FREETYPE2_CFLAGS) $(PANGO_FT2_CFLAGS)
A space is missing here.

[lilypond-pkx, 2019-06-04 19:51:41]

https://codereview.appspot.com/552770043/diff/574790043/aclocal.m4
File aclocal.m4 (right):

https://codereview.appspot.com/552770043/diff/574790043/aclocal.m4#newcode1291
aclocal.m4:1291: save_CPPFLAGS="$CPPFLAGS"
On 2019/06/04 05:40:35, lemzwerg wrote:
> we probably should replace tabs with spaces ...

Done.

https://codereview.appspot.com/552770043/diff/574790043/config.make.in
File config.make.in (right):

https://codereview.appspot.com/552770043/diff/574790043/config.make.in#newcode23
config.make.in:23: CONFIG_CFLAGS = @CFLAGS@ $(GLIB_CFLAGS)$(GUILE_CFLAGS)
$(FREETYPE2_CFLAGS) $(PANGO_FT2_CFLAGS)
On 2019/06/04 05:40:35, lemzwerg wrote:
> A space is missing here.

Done.

[lilypond-pkx, 2019-06-04 19:54:16]

with Werner's edits - thanks.

[lemzwerg, 2019-06-07 06:47:17]

Indentation problems...

https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4
File aclocal.m4 (right):

https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4#newcode77
aclocal.m4:77: STEPMAKE_ADD_ENTRY($3, $2)
This looks strange, at least here in appspot.  It appears as if one level of
indentation got lost.

https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4#newcode96
aclocal.m4:96: true
Ditto, and many other lines in this file, too.

https://codereview.appspot.com/552770043/diff/574800043/configure.ac
File configure.ac (right):

https://codereview.appspot.com/552770043/diff/574800043/configure.ac#newcode286
configure.ac:286: STEPMAKE_GLIB(glib-2.0, REQUIRED,2.44)
I suggest a space before `2.44' here and in the next line.

[lilypond-pkx, 2019-06-08 12:03:49]

Fixed indent from tab-to-space conversion, removed EOL whitespaces.

[lilypond-pkx, 2019-06-08 12:04:10]

https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4
File aclocal.m4 (right):

https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4#newcode77
aclocal.m4:77: STEPMAKE_ADD_ENTRY($3, $2)
On 2019/06/07 06:47:17, lemzwerg wrote:
> This looks strange, at least here in appspot.  It appears as if one level of
> indentation got lost.

Done.

https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4#newcode96
aclocal.m4:96: true
On 2019/06/07 06:47:17, lemzwerg wrote:
> Ditto, and many other lines in this file, too.

Yes, I guess find/replace didn't work. I'll fix these manually.

https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4#newcode399
aclocal.m4:399: fi
Cannot see corresponding 'if' line for this 'fi'. Again I maybe missing
something obvious.

[lilypond-pkx, 2019-06-14 19:16:23]

Werner's own patch

[lemzwerg, 2019-06-15 05:17:57]

Are you sure this is my patch set?  In the comparison view I see many » signs,
which usually indicate tabs.  However, the file I've sent to you doesn't contain
any tabs.

[lilypond-pkx, 2019-06-16 19:17:10]

This has moved to http://codereview.appspot.com/568820043

I am closing this one.