Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(182)

Issue 551270043: Doc: NR - Doc CSS colour support

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by pkx166h-lilypond
Modified:
4 years, 3 months ago
Reviewers:
dak, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR - Doc CSS colour support Issue 5537 Document support for CSS colour. This function was added in commit 7ecc24c5 Includes minor layout fixes and edits to incorporate both X11 and CSS support in the same NR section and appendixes. (note: as this enhancement is already in 2.20 branch, I have created a new tracker (#5644) specifically for the changes.tely entry so that it can be merged into 2.20 separately.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Typos from Werner L. #

Patch Set 3 : Removal of i.e. and e.g. (and so ugly commas) #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -44 lines) Patch
M Documentation/notation/editorial.itely View 1 2 3 chunks +39 lines, -34 lines 2 comments Download
M Documentation/notation/notation-appendices.itely View 1 2 2 chunks +50 lines, -10 lines 0 comments Download

Messages

Total messages: 10
lemzwerg
LGTM, with some minor remarks. https://codereview.appspot.com/551270043/diff/575420043/Documentation/notation/editorial.itely File Documentation/notation/editorial.itely (right): https://codereview.appspot.com/551270043/diff/575420043/Documentation/notation/editorial.itely#newcode496 Documentation/notation/editorial.itely:496: symbol in the form ...
4 years, 3 months ago (2019-12-18 18:02:34 UTC) #1
pkx166h-lilypond
Typos from Werner L.
4 years, 3 months ago (2019-12-19 11:34:19 UTC) #2
pkx166h-lilypond
https://codereview.appspot.com/551270043/diff/575420043/Documentation/notation/editorial.itely File Documentation/notation/editorial.itely (right): https://codereview.appspot.com/551270043/diff/575420043/Documentation/notation/editorial.itely#newcode496 Documentation/notation/editorial.itely:496: symbol in the form @code{'@var{FooBar}} or a string in ...
4 years, 3 months ago (2019-12-19 11:35:06 UTC) #3
lemzwerg
> > There should always a comma after 'i.e.', as far as I know. > ...
4 years, 3 months ago (2019-12-20 00:01:59 UTC) #4
dak
On 2019/12/20 00:01:59, lemzwerg wrote: > > > There should always a comma after 'i.e.', ...
4 years, 3 months ago (2019-12-20 00:45:05 UTC) #5
pkx166h-lilypond
Removal of i.e. and e.g. (and so ugly commas)
4 years, 3 months ago (2019-12-21 09:47:49 UTC) #6
pkx166h-lilypond
On 2019/12/20 00:45:05, dak wrote: > On 2019/12/20 00:01:59, lemzwerg wrote: > > > > ...
4 years, 3 months ago (2019-12-21 10:28:13 UTC) #7
lemzwerg
LGTM, thanks! https://codereview.appspot.com/551270043/diff/583260043/Documentation/notation/editorial.itely File Documentation/notation/editorial.itely (right): https://codereview.appspot.com/551270043/diff/583260043/Documentation/notation/editorial.itely#newcode576 Documentation/notation/editorial.itely:576: X11 and CSS colors will not always ...
4 years, 3 months ago (2019-12-21 15:34:57 UTC) #8
lemzwerg
> > > I'm not a native speaker, but I think exactly the opposite, > ...
4 years, 3 months ago (2019-12-21 15:40:45 UTC) #9
lemzwerg
4 years, 3 months ago (2019-12-21 15:42:14 UTC) #10
> I don't mind if we follow a different style.  What would
> you recommend?

Of course, changing the style would mean that all occurrences should be fixed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b