Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments. Please
Sign in
to add in-line comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(85)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Side by Side Diff: src/pkg/runtime/race/race_darwin_amd64.syso
Issue
55100044
:
code review 55100044: runtime: use custom thunks for race calls instead of cgo (Closed)
Patch Set: diff -r 340da08f5f54 https://dvyukov%40google.com@code.google.com/p/go/
Created 10 years ago
Left:
Base
Patch Set 1: None
Patch Set 2: diff -r 09a55add2bb5 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 3: diff -r 09a55add2bb5 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 4: diff -r 09a55add2bb5 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 5: diff -r 09a55add2bb5 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 6: diff -r 09a55add2bb5 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 7: diff -r 09a55add2bb5 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 8: diff -r 09a55add2bb5 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 9: diff -r 09a55add2bb5 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 10: diff -r d92b32d188ec https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 11: diff -r d92b32d188ec https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 12: diff -r efb71a1d099d https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 13: diff -r efb71a1d099d https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 14: diff -r d2e78612ed03 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 15: diff -r 7473ad4d05c3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 16: diff -r 7473ad4d05c3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 17: diff -r 7473ad4d05c3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 18: diff -r 7473ad4d05c3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 19: diff -r 7473ad4d05c3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 20: diff -r 7473ad4d05c3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 21: diff -r 7473ad4d05c3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 22: diff -r d067c6de4ec3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 23: diff -r d067c6de4ec3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 24: diff -r d067c6de4ec3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 25: diff -r d067c6de4ec3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 26: diff -r ae14bde9ce3c https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 27: diff -r ae14bde9ce3c https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 28: diff -r ae14bde9ce3c https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 29: diff -r ae14bde9ce3c https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 30: diff -r ae14bde9ce3c https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 31: diff -r ae14bde9ce3c https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 32: diff -r ae14bde9ce3c https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 33: diff -r 27a1bda549a2 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 34: diff -r 27a1bda549a2 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 35: diff -r 27a1bda549a2 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 36: diff -r 5f58c6d04b6d https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 37: diff -r 32f0dc88f804 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 38: diff -r 32f0dc88f804 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 39: diff -r 7a45730704af https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 40: diff -r 340da08f5f54 https://dvyukov%40google.com@code.google.com/p/go/
Right:
Patch Set 1: None
Patch Set 2: diff -r 09a55add2bb5 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 3: diff -r 09a55add2bb5 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 4: diff -r 09a55add2bb5 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 5: diff -r 09a55add2bb5 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 6: diff -r 09a55add2bb5 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 7: diff -r 09a55add2bb5 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 8: diff -r 09a55add2bb5 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 9: diff -r 09a55add2bb5 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 10: diff -r d92b32d188ec https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 11: diff -r d92b32d188ec https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 12: diff -r efb71a1d099d https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 13: diff -r efb71a1d099d https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 14: diff -r d2e78612ed03 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 15: diff -r 7473ad4d05c3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 16: diff -r 7473ad4d05c3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 17: diff -r 7473ad4d05c3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 18: diff -r 7473ad4d05c3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 19: diff -r 7473ad4d05c3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 20: diff -r 7473ad4d05c3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 21: diff -r 7473ad4d05c3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 22: diff -r d067c6de4ec3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 23: diff -r d067c6de4ec3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 24: diff -r d067c6de4ec3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 25: diff -r d067c6de4ec3 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 26: diff -r ae14bde9ce3c https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 27: diff -r ae14bde9ce3c https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 28: diff -r ae14bde9ce3c https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 29: diff -r ae14bde9ce3c https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 30: diff -r ae14bde9ce3c https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 31: diff -r ae14bde9ce3c https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 32: diff -r ae14bde9ce3c https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 33: diff -r 27a1bda549a2 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 34: diff -r 27a1bda549a2 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 35: diff -r 27a1bda549a2 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 36: diff -r 5f58c6d04b6d https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 37: diff -r 32f0dc88f804 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 38: diff -r 32f0dc88f804 https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 39: diff -r 7a45730704af https://dvyukov%40google.com@code.google.com/p/go/
Patch Set 40: diff -r 340da08f5f54 https://dvyukov%40google.com@code.google.com/p/go/
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Jump to:
src/pkg/runtime/cgocall.c
src/pkg/runtime/malloc.goc
src/pkg/runtime/proc.c
src/pkg/runtime/race.h
src/pkg/runtime/race.c
src/pkg/runtime/race/README
src/pkg/runtime/race/race.go
src/pkg/runtime/race/race_darwin_amd64.syso
src/pkg/runtime/race/race_linux_amd64.syso
src/pkg/runtime/race/race_windows_amd64.syso
src/pkg/runtime/race0.c
src/pkg/runtime/race_amd64.s
src/pkg/runtime/runtime.h
View unified diff
|
Download patch
« no previous file with comments
|
« src/pkg/runtime/race/race.go
('k') |
src/pkg/runtime/race/race_linux_amd64.syso »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
OLD
NEW
« no previous file with comments
|
« src/pkg/runtime/race/race.go
('k') |
src/pkg/runtime/race/race_linux_amd64.syso »
('j') |
no next file with comments »
Issue 55100044: code review 55100044: runtime: use custom thunks for race calls instead of cgo (Closed)
Created 10 years, 2 months ago by dvyukov
Modified 10 years ago
Reviewers: gobot
Base URL:
Comments: 15
Recent Issues
|
This issue
This is Rietveld
f62528b