Issue 549820043: Fix line comments for new snippets

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 549820043: Fix line comments for new snippets

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years ago by dak

Modified:
4 years ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Fix line comments for new snippets LilyPond line comments should start with "%%" but snippets generated from Documentation/snippets/new/*.ly previously only used single percent signs.

Patch Set 1 #

Total comments: 1

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	scripts/auxiliar/makelsr.py	View		1 chunk	+5 lines, -5 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dak

On 2020/04/06 12:40:50, lemzwerg wrote: > LGTM, and please push directly. I'd rather not have ...

4 years ago (2020-04-06 12:43:37 UTC) #2

lemzwerg

> I'd rather not have 2.21.0 in a state inconsistent > with its makelsr program. ...

4 years ago (2020-04-06 12:46:05 UTC) #3

dak

4 years ago (2020-04-11 09:51:34 UTC) #4

https://codereview.appspot.com/549820043/diff/565880043/scripts/auxiliar/make...
File scripts/auxiliar/makelsr.py (right):

https://codereview.appspot.com/549820043/diff/565880043/scripts/auxiliar/make...
scripts/auxiliar/makelsr.py:38: new_lys_marker = "%% generated from %s" %
new_lys
Embarrassingly, this needs to be %%%% as well as I discovered right now before
pushing.  I decided not to restart the review for this.

Expand All Messages | Collapse All Messages