Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(811)

Issue 549810043: python: fix installation of .py files when building in separate dir (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by hanwenn
Modified:
3 years, 11 months ago
Reviewers:
hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

python: fix installation of .py files when building in separate dir

Patch Set 1 #

Patch Set 2 : suppress __pycache__ #

Total comments: 3

Patch Set 3 : jonas' comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M make/lilypond-vars.make View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M python/GNUmakefile View 1 2 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 9
hahnjo
I think we should rather do https://codereview.appspot.com/575960043
3 years, 11 months ago (2020-04-05 21:41:31 UTC) #1
hanwenn
suppress __pycache__
3 years, 11 months ago (2020-04-06 19:51:11 UTC) #2
hahnjo
On 2020/04/06 19:51:11, hanwenn wrote: > suppress __pycache__ The suppression only works for the test. ...
3 years, 11 months ago (2020-04-06 20:33:45 UTC) #3
hahnjo
I could probably be happy with the following: diff --git a/make/lilypond-vars.make b/make/lilypond-vars.make index 3f1e992626..3ac59f19a4 100644 ...
3 years, 11 months ago (2020-04-06 21:11:30 UTC) #4
hahnjo
https://codereview.appspot.com/549810043/diff/567420043/python/GNUmakefile File python/GNUmakefile (right): https://codereview.appspot.com/549810043/diff/567420043/python/GNUmakefile#newcode20 python/GNUmakefile:20: INSTALLATION_OUT_SUFFIXES = 2 please drop entirely https://codereview.appspot.com/549810043/diff/567420043/python/GNUmakefile#newcode26 python/GNUmakefile:26: INSTALLATION_OUT_FILES2 ...
3 years, 11 months ago (2020-04-07 15:47:17 UTC) #5
hanwenn
jonas' comments
3 years, 11 months ago (2020-04-07 19:21:53 UTC) #6
hahnjo
LGTM. I think you should push this unblock 2.21.0
3 years, 11 months ago (2020-04-07 19:44:01 UTC) #7
hanwenn
On Tue, Apr 7, 2020 at 9:44 PM <jonas.hahnfeld@gmail.com> wrote: > > LGTM. I think ...
3 years, 11 months ago (2020-04-08 08:11:59 UTC) #8
hanwenn
3 years, 11 months ago (2020-04-09 17:30:57 UTC) #9
commit 2fc91caabe6adb61c89915f659e35f3ec8ba5c62 (py-install)
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Sun Apr 5 23:07:56 2020 +0200
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b