Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(235)

Issue 5496066: code review 5496066: vim: fix go filetype detection

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by tones111
Modified:
2 years, 4 months ago
Reviewers:
dsymonds
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

vim: fix go filetype detection

The filetype needs to be set during BufRead in order for the did_filetype()
check to prevent the file being detected as a conf file.  One example where this
can occur is if a cgo file has a #include at the top of the file.  The # is
detected in vim's generic configuration (conf file) toward the bottom of
filetype.vim

Patch Set 1 #

Patch Set 2 : diff -r 0c39eee85b0d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 15b63cc10b22 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M misc/vim/ftdetect/gofiletype.vim View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
tones111
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
2 years, 4 months ago #1
dsymonds
LGTM
2 years, 4 months ago #2
dsymonds
2 years, 4 months ago #3
*** Submitted as http://code.google.com/p/go/source/detail?r=fe3bea7c6c36 ***

vim: fix go filetype detection

The filetype needs to be set during BufRead in order for the did_filetype()
check to prevent the file being detected as a conf file.  One example where this
can occur is if a cgo file has a #include at the top of the file.  The # is
detected in vim's generic configuration (conf file) toward the bottom of
filetype.vim

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5496066

Committer: David Symonds <dsymonds@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5