Issue 549560043: Add a RAII wrapper for extracting FT_Face from PangoFcFont

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 549560043: Add a RAII wrapper for extracting FT_Face from PangoFcFont (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 2 months ago by hanwenn

Modified:
4 years, 1 month ago

Reviewers:
lemzwerg, hahnjo

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Add a RAII wrapper for extracting FT_Face from PangoFcFont This reduces the number of deprecation warnings for pango_fc_font_[un]lock_face().

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -10 lines)			Patch
	M	lily/pango-font.cc	View		7 chunks	+28 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hanwenn

4 years, 1 month ago (2020-02-21 15:23:01 UTC) #3

commit 9cf8d35e8c0ebf0f2b56ec74d3b0187b2cd493b8
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Thu Feb 13 14:26:55 2020 +0100

    Add a RAII wrapper for extracting FT_Face from PangoFcFont

Expand All Messages | Collapse All Messages