Issue 549510043: Rewrite define-session and define-session-public macros

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 549510043: Rewrite define-session and define-session-public macros (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 2 months ago by dak

Modified:
4 years, 2 months ago

Reviewers:
hanwenn

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Rewrite define-session and define-session-public macros The byte compiler of Guile-2.x is not able to compile anonymous functions/closures into constants. Rewriting the macros not to rely on such constants by moving the local functions into their own function definitions is the easiest expedient.

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -9 lines)			Patch
	M	scm/lily.scm	View		4 chunks	+15 lines, -9 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

hanwenn

4 years, 2 months ago (2020-02-19 09:43:37 UTC) #2

please close issue.


commit c066a53f9e3a4809283ba2934a2e8f1e6c44211b
Author: David Kastrup <dak@gnu.org>
Date:   Tue Feb 4 22:02:20 2020 +0100

    Issue 5735: Rewrite define-session and define-session-public macros

Expand All Messages | Collapse All Messages