Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(63)

Issue 548080043: Add OTC font support for `-dfont-ps-resdir`

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by trueroad
Modified:
4 weeks ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add OTC font support for `-dfont-ps-resdir` This commit adds support for OpenType/CFF collection (OTC) fonts to the `-dfont-ps-resdir` option. Add `ly:extract-subfont-from-collection` Extract the subfont in TrueType collection (TTC) or OpenType/CFF collection (OTC) file and write it to file.

Patch Set 1 #

Total comments: 22

Patch Set 2 : Improve messages #

Total comments: 8

Patch Set 3 : Improve messages again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+355 lines, -5 lines) Patch
M Documentation/usage/running.itely View 1 2 chunks +1 line, -3 lines 0 comments Download
M lily/open-type-font-scheme.cc View 1 2 1 chunk +346 lines, -0 lines 0 comments Download
M scm/framework-ps.scm View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7
lemzwerg
LGTM, with some nits https://codereview.appspot.com/548080043/diff/573790043/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/548080043/diff/573790043/Documentation/usage/running.itely#newcode663 Documentation/usage/running.itely:663: this method cannnot embed CID ...
1 month ago (2020-05-03 15:20:17 UTC) #1
trueroad
Improve messages
1 month ago (2020-05-04 02:21:25 UTC) #2
trueroad
Thank you for your reviewing. https://codereview.appspot.com/548080043/diff/573790043/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/548080043/diff/573790043/Documentation/usage/running.itely#newcode663 Documentation/usage/running.itely:663: this method cannnot embed ...
1 month ago (2020-05-04 02:33:27 UTC) #3
lemzwerg
Thanks for the changes. Here the next round of comments :-) https://codereview.appspot.com/548080043/diff/567530058/lily/open-type-font-scheme.cc File lily/open-type-font-scheme.cc (right): ...
1 month ago (2020-05-04 04:33:59 UTC) #4
trueroad
Improve messages again
1 month ago (2020-05-04 05:43:28 UTC) #5
trueroad
Thank you for your reviewing. https://codereview.appspot.com/548080043/diff/567530058/lily/open-type-font-scheme.cc File lily/open-type-font-scheme.cc (right): https://codereview.appspot.com/548080043/diff/567530058/lily/open-type-font-scheme.cc#newcode467 lily/open-type-font-scheme.cc:467: warning (_f ("font index ...
1 month ago (2020-05-04 05:45:23 UTC) #6
trueroad
4 weeks ago (2020-05-09 09:03:43 UTC) #7
I've pushed to staging.

commit 116b2765ea458daa4ab32a7ecaff79eb0ab5306f
Issue 5960/3: Doc: Remove unnecessary description about `-dfont-ps-resdir`

commit a2ff250f1fb4adb23c82000affe475ef34820cc6
Issue 5960/2: Add OTC font support for `-dfont-ps-resdir`

commit 92db18d3141484d3c46722f6ed911c253e06d0f4
Issue 5960/1: Add `ly:extract-subfont-from-collection`
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b