Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

Issue 547620043: engraver: continue when trying to create non-existent Grob (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 4 days ago by hanwenn
Modified:
1 week, 2 days ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

engraver: continue when trying to create non-existent Grob

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M lily/engraver.cc View 1 chunk +19 lines, -16 lines 1 comment Download

Messages

Total messages: 5
dak
https://codereview.appspot.com/547620043/diff/545560043/lily/engraver.cc File lily/engraver.cc (right): https://codereview.appspot.com/547620043/diff/545560043/lily/engraver.cc#newcode126 lily/engraver.cc:126: grob = new Item (SCM_EOL); Ugh. How is that ...
2 weeks, 4 days ago (2020-02-10 21:31:46 UTC) #1
hanwenn
On 2020/02/10 21:31:46, dak wrote: > https://codereview.appspot.com/547620043/diff/545560043/lily/engraver.cc > File lily/engraver.cc (right): > > https://codereview.appspot.com/547620043/diff/545560043/lily/engraver.cc#newcode126 > ...
2 weeks, 4 days ago (2020-02-10 21:35:30 UTC) #2
dak
On 2020/02/10 21:35:30, hanwenn wrote: > On 2020/02/10 21:31:46, dak wrote: > > https://codereview.appspot.com/547620043/diff/545560043/lily/engraver.cc > ...
2 weeks, 4 days ago (2020-02-10 21:40:03 UTC) #3
hanwenn
On 2020/02/10 21:40:03, dak wrote: > On 2020/02/10 21:35:30, hanwenn wrote: > > On 2020/02/10 ...
2 weeks, 4 days ago (2020-02-10 21:41:36 UTC) #4
hanwenn
1 week, 2 days ago (2020-02-19 09:35:32 UTC) #5
commit c3cb10296708a2efcdac03d02507c9b55e3aa42c
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Mon Feb 10 22:12:41 2020 +0100

    engraver: continue when trying to create non-existent Grob
    
    https://sourceforge.net/p/testlilyissues/issues/5748
    http://codereview.appspot.com/547620043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b