Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7613)

Issue 545950043: Add a script for running timing benchmarks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by hanwenn
Modified:
3 years, 12 months ago
Reviewers:
valentin, dak, hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add a script for running timing benchmarks

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -0 lines) Patch
A scripts/auxiliar/benchmark.py View 1 chunk +97 lines, -0 lines 0 comments Download

Messages

Total messages: 7
hahnjo
I strongly object to adding more random scripts to the source tree. There are already ...
4 years ago (2020-04-25 17:07:17 UTC) #1
hanwenn
sure.
4 years ago (2020-04-25 17:12:44 UTC) #2
dak
On 2020/04/25 17:07:17, hahnjo wrote: > I strongly object to adding more random scripts to ...
4 years ago (2020-04-25 22:05:26 UTC) #3
hanwenn
On 2020/04/25 22:05:26, dak wrote: > On 2020/04/25 17:07:17, hahnjo wrote: > > I strongly ...
3 years, 12 months ago (2020-04-26 06:56:23 UTC) #4
hahnjo
On 2020/04/25 22:05:26, dak wrote: > On 2020/04/25 17:07:17, hahnjo wrote: > > I strongly ...
3 years, 12 months ago (2020-04-26 07:38:56 UTC) #5
valentin_villenave.net
On 4/26/20, hanwenn@gmail.com <hanwenn@gmail.com> wrote: > I can host this script somewhere else so it ...
3 years, 12 months ago (2020-04-26 20:04:19 UTC) #6
hanwenn
3 years, 12 months ago (2020-04-27 06:48:44 UTC) #7
On Sun, Apr 26, 2020 at 10:04 PM Valentin Villenave
<valentin@villenave.net> wrote:
>
> On 4/26/20, hanwenn@gmail.com <hanwenn@gmail.com> wrote:
> > I can host this script somewhere else so it can be referenced in the CG,
> > but I don't think there optimizing our C++ code  is a domain for
> > beginners.
>
> I may be off the mark here, but what about adding your speed test into
> the standard regression test suite? I know the regtests are already
> measured for compilation time, but IIRC there’s no middle-size score
> compilation such as the horn thing, separate from the rest,
> specifically to get an inkling as to which changes in the codebase may
> result in speed gains or unwanted slowdowns (not noticeable
> otherwise). If this means adding 20s or so to `make check’, couldn’t
> that be a bargain worth discussing?

It doesn't work.

1) You need to have a machine doing nothing else. Even web browsing in
the background will mess with shared L3 caches.
2) This always does comparisons. So you need to have a binary of the
previous version available as well. The current setup doesn't produce
that.
3) We used to have a CPU time field in our regtest (look for .profile)
files, but they were too noisy and were switched off.

-- 
Han-Wen Nienhuys - hanwenn@gmail.com - http://www.xs4all.nl/~hanwen
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b