Issue 545100043: Issue 5588: fix color-profile warning in output-distance

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 545100043: Issue 5588: fix color-profile warning in output-distance (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 5 months ago by Dan Eble

Modified:
4 years, 5 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

https://sourceforge.net/p/testlilyissues/issues/5588/ The warning is "RGB color space not permitted on grayscale PNG" and the solution is to strip the profile from the image.

Patch Set 2 : use -strip #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	scripts/build/output-distance.py	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

lemzwerg

LGTM https://codereview.appspot.com/545100043/diff/545110043/scripts/build/output-distance.py File scripts/build/output-distance.py (right): https://codereview.appspot.com/545100043/diff/545110043/scripts/build/output-distance.py#newcode100 scripts/build/output-distance.py:100: system ('convert +profile icc -depth 8 -crop %dx%d+0+0 ...

4 years, 5 months ago (2019-10-26 04:46:40 UTC) #2

LGTM

Expand All Messages | Collapse All Messages