juju/ec2: add access key and secret key to configuration file.

https://code.launchpad.net/~rogpeppe/juju/go-juju-ec2-config-auth/+merge/84606

(do not edit description out of merge proposal)

[niemeyer, 2011-12-06 13:04:24]

Nice, LGTM.

https://codereview.appspot.com/5449103/diff/2001/juju/ec2/config.go
File juju/ec2/config.go (right):

https://codereview.appspot.com/5449103/diff/2001/juju/ec2/config.go#newcode37
juju/ec2/config.go:37: "secret-key": schema.String(),
In this situation, it feels more useful to have related keys close together than
to order them entirely alphabetically (access and secret key will end up quite
far apart despite being so closely related).

https://codereview.appspot.com/5449103/diff/2001/juju/ec2/config.go#newcode56
juju/ec2/config.go:56: }
Nice checks.

https://codereview.appspot.com/5449103/diff/2001/juju/ec2/config_test.go
File juju/ec2/config_test.go (right):

https://codereview.appspot.com/5449103/diff/2001/juju/ec2/config_test.go#newc...
juju/ec2/config_test.go:15: var defa = aws.Auth{"gopher", "long teeth"}
s/defa/testAuth/

[rog, 2011-12-06 13:15:06]

PTAL

https://codereview.appspot.com/5449103/diff/2001/juju/ec2/config.go
File juju/ec2/config.go (right):

https://codereview.appspot.com/5449103/diff/2001/juju/ec2/config.go#newcode37
juju/ec2/config.go:37: "secret-key": schema.String(),
On 2011/12/06 13:04:25, niemeyer wrote:
> In this situation, it feels more useful to have related keys close together
than
> to order them entirely alphabetically (access and secret key will end up quite
> far apart despite being so closely related).

that's how i had it originally, but i went with alphabetic eventually because
there are three independent lists that must be kept in sync, and i found it
easier to track them when they were all in alphabetic order (more of an issue
when all the attributes are there). i'll change it back though.

https://codereview.appspot.com/5449103/diff/2001/juju/ec2/config_test.go
File juju/ec2/config_test.go (right):

https://codereview.appspot.com/5449103/diff/2001/juju/ec2/config_test.go#newc...
juju/ec2/config_test.go:15: var defa = aws.Auth{"gopher", "long teeth"}
On 2011/12/06 13:04:25, niemeyer wrote:
> s/defa/testAuth/

Done. Interestingly, I did have "defr = aws.USEast" here too (default is a more
appropriate adjective in that case), but it triggered a compiler crash, issue
2529.

[niemeyer, 2011-12-06 13:20:25]

LGTM, thanks for the changes.

[niemeyer, 2011-12-13 22:05:30]

This was already merged.