Issue 5440056: gozk/zk: fixes for new error type

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5440056: gozk/zk: fixes for new error type

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by rog

Modified:
12 years, 4 months ago

Reviewers:
mp+83816

Visibility:
Public.

Description

gozk/zk: fixes for new error type https://code.launchpad.net/~rogpeppe/gozk/zk-error-fixes/+merge/83816 (do not edit description out of merge proposal)

Patch Set 2 : - #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -60 lines)			Patch
M	retry_test.go	View	1	10 chunks	+13 lines, -13 lines	0 comments	Download
M	server.go	View	1	6 chunks	+10 lines, -9 lines	0 comments	Download
M	suite_test.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	zk.go	View	1	22 chunks	+28 lines, -29 lines	0 comments	Download
M	zk_test.go	View	1	5 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

Beautiful, LGTM, with one detail: https://codereview.appspot.com/5440056/diff/1/zk_test.go File zk_test.go (right): https://codereview.appspot.com/5440056/diff/1/zk_test.go#newcode305 zk_test.go:305: c.Assert(len(children), Equals, 0) IsNil?

12 years, 5 months ago (2011-11-29 17:32:33 UTC) #1

rog

https://codereview.appspot.com/5440056/diff/1/zk_test.go File zk_test.go (right): https://codereview.appspot.com/5440056/diff/1/zk_test.go#newcode305 zk_test.go:305: c.Assert(len(children), Equals, 0) On 2011/11/29 17:32:33, niemeyer wrote: > ...

12 years, 5 months ago (2011-11-29 17:34:53 UTC) #2

Expand All Messages | Collapse All Messages