Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1766)

Issue 5437059: Don't let dots go negative in scaleDurations -- Fix Issue 2048 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by Carl
Modified:
7 years, 6 months ago
Reviewers:
Keith, pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Don't let dots go negative in scaleDurations -- Fix Issue 2048

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix regtest and respond to Keith's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
A input/regression/shift-durations-negative-dots.ly View 1 1 chunk +12 lines, -0 lines 0 comments Download
M ly/music-functions-init.ly View 1 1 chunk +2 lines, -1 line 0 comments Download
M scm/music-functions.scm View 1 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 4
Keith
Looks and works good for me. A nice thing about scheme patches is we can ...
7 years, 7 months ago (2011-11-24 18:51:21 UTC) #1
pkx166h
passes make but fails make check see http://code.google.com/p/lilypond/issues/detail?id=2048#c3 James
7 years, 7 months ago (2011-11-24 21:04:47 UTC) #2
Keith
http://codereview.appspot.com/5437059/diff/1/input/regression/shift-durations-negative-dots.ly File input/regression/shift-durations-negative-dots.ly (right): http://codereview.appspot.com/5437059/diff/1/input/regression/shift-durations-negative-dots.ly#newcode8 input/regression/shift-durations-negative-dots.ly:8: " '}' Or, we might do without a regression ...
7 years, 7 months ago (2011-11-24 23:30:36 UTC) #3
pkx166h
7 years, 7 months ago (2011-11-25 08:36:48 UTC) #4
passes make one reg test shows up

http://code.google.com/p/lilypond/issues/detail?id=2048#c5

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b