Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2349)

Issue 5433065: Asserts that footnotes are being numbered correctly. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by MikeSol
Modified:
7 years, 10 months ago
Reviewers:
pkx166h, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Asserts that footnotes are being numbered correctly.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporates Carl's suggestions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -11 lines) Patch
M input/regression/footnote-auto-numbering.ly View 4 chunks +25 lines, -3 lines 0 comments Download
A input/regression/footnote-auto-numbering-vertical-order.ly View 1 chunk +97 lines, -0 lines 0 comments Download
M lily/include/page-layout-problem.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/page-layout-problem.cc View 5 chunks +22 lines, -7 lines 0 comments Download
M scm/define-grob-interfaces.scm View 1 1 chunk +4 lines, -1 line 0 comments Download
M scm/define-grob-properties.scm View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
MikeSol
Hey all, This patch helps make sure that the footnote auto-number regtests actually test what ...
7 years, 11 months ago (2011-11-25 04:42:43 UTC) #1
pkx166h
Passes make and make check James
7 years, 11 months ago (2011-11-25 20:50:06 UTC) #2
Carl
LGTM, but a couple of minor comments. http://codereview.appspot.com/5433065/diff/1/scm/define-grob-interfaces.scm File scm/define-grob-interfaces.scm (right): http://codereview.appspot.com/5433065/diff/1/scm/define-grob-interfaces.scm#newcode88 scm/define-grob-interfaces.scm:88: numbering-assertion-function)) spacing. ...
7 years, 10 months ago (2011-11-28 01:38:02 UTC) #3
pkx166h
7 years, 10 months ago (2011-11-28 17:13:08 UTC) #4
Passes make and make check

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b