Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1772)

Issue 5432070: Uses the pure-from-neighbor-interface for NonMusicalPaperColumn horizontal spacing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by MikeSol
Modified:
7 years, 6 months ago
Reviewers:
pkx166h, Keith, mike, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Uses the pure-from-neighbor-interface for NonMusicalPaperColumn horizontal spacing.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Response to Keith's comments. #

Patch Set 3 : With Keith's suggestions. #

Patch Set 4 : Changes regtest, fixes TimeSignature extra-spacing-height. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -25 lines) Patch
M input/regression/spacing-folded-clef3.ly View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
M lily/spacing-loose-columns.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 2 3 11 chunks +24 lines, -23 lines 0 comments Download
M scm/output-lib.scm View 1 2 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 15
MikeSol
This is the second of the three-part pure-from-neighbor-interface code rewrite. It uses extra-spacing-height for certain ...
7 years, 7 months ago (2011-11-25 05:27:53 UTC) #1
MikeSol
Sorry, forgot to mention that for the time being this only applies cleanly to the ...
7 years, 7 months ago (2011-11-25 05:31:57 UTC) #2
pkx166h
Passes Make, all reg test diffs here http://code.google.com/p/lilypond/issues/detail?id=2053#c1 James
7 years, 7 months ago (2011-11-25 20:58:06 UTC) #3
pkx166h
On 2011/11/25 05:31:57, MikeSol wrote: > Sorry, forgot to mention that for the time being ...
7 years, 7 months ago (2011-11-25 20:58:29 UTC) #4
Keith
looks good to me, after putting back skyline-vertical-padding for just one more round. http://codereview.appspot.com/5432070/diff/1/input/regression/lyrics-pass-under-bar.ly File ...
7 years, 7 months ago (2011-11-26 01:08:19 UTC) #5
Keith
http://codereview.appspot.com/5432070/diff/1/scm/define-grobs.scm File scm/define-grobs.scm (right): http://codereview.appspot.com/5432070/diff/1/scm/define-grobs.scm#newcode2282 scm/define-grobs.scm:2282: (extra-spacing-height . (-1.0 . 1.0)) delete the second extra-spacing-height
7 years, 7 months ago (2011-11-26 04:33:15 UTC) #6
pkx166h
Passes Make - reg tests here: http://lilypond-stuff.1065243.n5.nabble.com/Tracker-2053-26-November-td5023673.html Jam
7 years, 7 months ago (2011-11-26 13:33:53 UTC) #7
Keith
Mike, Maybe change-clefs should not get the full extra-spacing-height by default. Engravers tend to tuck ...
7 years, 7 months ago (2011-11-26 20:55:50 UTC) #8
mike_apollinemike.com
On Nov 26, 2011, at 9:56 PM, Keith OHara wrote: > Mike, Maybe change-clefs should ...
7 years, 7 months ago (2011-11-26 22:48:36 UTC) #9
Keith
On Sat, 26 Nov 2011 14:48:29 -0800, mike@apollinemike.com <mike@apollinemike.com> wrote: > On Nov 26, 2011, ...
7 years, 7 months ago (2011-11-27 00:21:00 UTC) #10
mike_apollinemike.com
On Nov 27, 2011, at 1:21 AM, Keith OHara wrote: > On Sat, 26 Nov ...
7 years, 7 months ago (2011-11-27 10:17:36 UTC) #11
pkx166h
Passes make. Reg tests all here: http://lilypond-stuff.1065243.n5.nabble.com/Tracker-2053-27-November-2011-td5026326.html James
7 years, 7 months ago (2011-11-27 12:05:23 UTC) #12
pkx166h
Passes Make. Reg tests http://lilypond-stuff.1065243.n5.nabble.com/Tracker-2053-27-November-2011-2-td5026960.html James
7 years, 7 months ago (2011-11-27 18:31:45 UTC) #13
Keith
On Sun, 27 Nov 2011 02:17:27 -0800, mike@apollinemike.com <mike@apollinemike.com> wrote: > But break_status_dir doesn't seem ...
7 years, 7 months ago (2011-11-27 19:28:23 UTC) #14
Carl
7 years, 7 months ago (2011-11-28 01:31:33 UTC) #15
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b