Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1338)

Issue 5432056: Skeleton framework for ec2 provider.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by rog
Modified:
8 years, 7 months ago
Reviewers:
mp+81998
Visibility:
Public.

Description

No ec2 functionality as yet, just the structure as yet. Includes new package, jujutest, for provider-independent testing of juju functionality. https://code.launchpad.net/~rogpeppe/juju/go-juju-initial-ec2/+merge/81998 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 20

Patch Set 2 : - #

Patch Set 3 : - #

Total comments: 10

Patch Set 4 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -17 lines) Patch
M juju/Makefile View 1 2 1 chunk +1 line, -1 line 0 comments Download
M juju/dummyprovider_test.go View 1 2 2 chunks +17 lines, -17 lines 0 comments Download
A juju/ec2/Makefile View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A juju/ec2/ec2.go View 1 2 1 chunk +102 lines, -0 lines 0 comments Download
A juju/ec2/ec2_test.go View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A juju/jujutest/Makefile View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A juju/jujutest/startstop.go View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A juju/jujutest/test.go View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M juju/open.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10
niemeyer
Bits outside of juju/ec2 look great as long as the minor points brought up are ...
8 years, 7 months ago (2011-11-30 21:23:26 UTC) #1
rog
> juju/ec2 is lacking severely in testing, and is a ton of logic without > ...
8 years, 7 months ago (2011-12-01 08:05:30 UTC) #2
gustavo_niemeyer.net
> Almost all of that logic is ported directly from the python code. I > ...
8 years, 7 months ago (2011-12-01 08:25:53 UTC) #3
rog
you're up early! On 1 December 2011 08:25, Gustavo Niemeyer <gustavo@niemeyer.net> wrote: >> Almost all ...
8 years, 7 months ago (2011-12-01 08:37:43 UTC) #4
gustavo_niemeyer.net
> I still don't see a good way to test this stuff, even local to ...
8 years, 7 months ago (2011-12-01 09:56:59 UTC) #5
rog
On 1 December 2011 09:56, Gustavo Niemeyer <gustavo@niemeyer.net> wrote: >> I still don't see a ...
8 years, 7 months ago (2011-12-01 09:59:28 UTC) #6
roger.peppe
On 1 December 2011 10:13, Gustavo Niemeyer <gustavo@niemeyer.net> wrote: >> i just realised, if we ...
8 years, 7 months ago (2011-12-01 10:29:32 UTC) #7
niemeyer
https://codereview.appspot.com/5432056/diff/8001/juju/ec2/ec2.go File juju/ec2/ec2.go (right): https://codereview.appspot.com/5432056/diff/8001/juju/ec2/ec2.go#newcode54 juju/ec2/ec2.go:54: // Open implements juju.EnvironProvider.Open Please drop the dummy documentation ...
8 years, 7 months ago (2011-12-02 14:34:44 UTC) #8
rog
PTAL https://codereview.appspot.com/5432056/diff/8001/juju/ec2/ec2.go File juju/ec2/ec2.go (right): https://codereview.appspot.com/5432056/diff/8001/juju/ec2/ec2.go#newcode54 juju/ec2/ec2.go:54: // Open implements juju.EnvironProvider.Open On 2011/12/02 14:34:44, niemeyer ...
8 years, 7 months ago (2011-12-02 14:51:10 UTC) #9
niemeyer
8 years, 7 months ago (2011-12-02 16:14:30 UTC) #10
This has been merged.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b