Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(864)

Issue 5431087: goyaml: omit zero-value pointers

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by rog
Modified:
12 years, 4 months ago
Reviewers:
mp+83603
Visibility:
Public.

Description

The documentation does not explicitly mention pointers when marshalling, but it seems within the spirit of the documentation that nil pointers should not be marshalled when the omitzero tag is set. This enables struct values to be omitted from the output if desired. https://code.launchpad.net/~rogpeppe/goyaml/goyaml-omit-zero-pointers/+merge/83603 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M encode_test.go View 1 chunk +4 lines, -0 lines 0 comments Download
M goyaml.go View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 3
niemeyer
Nice, LGTM https://codereview.appspot.com/5431087/diff/1/goyaml.go File goyaml.go (right): https://codereview.appspot.com/5431087/diff/1/goyaml.go#newcode266 goyaml.go:266: return v.IsNil() You can join this to ...
12 years, 5 months ago (2011-11-28 13:18:05 UTC) #1
rog
On 28 November 2011 13:18, <n13m3y3r@gmail.com> wrote: > https://codereview.appspot.com/5431087/diff/1/goyaml.go#newcode266 > goyaml.go:266: return v.IsNil() > You ...
12 years, 5 months ago (2011-11-28 13:26:19 UTC) #2
niemeyer
12 years, 4 months ago (2011-12-01 12:34:50 UTC) #3

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b