Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1632)

Issue 5431065: Better pure heights for slurs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by MikeSol
Modified:
7 years, 6 months ago
Reviewers:
pkx166h, Keith, wl, mike
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Better pure heights for slurs

Patch Set 1 #

Total comments: 3

Patch Set 2 : Incorporates Keith's suggestions. #

Patch Set 3 : Third stab at approximating pure slur heights. #

Total comments: 4

Patch Set 4 : Fixes bug in loop to get correct extents. #

Total comments: 4

Patch Set 5 : Incorporates Keith's suggestions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -6 lines) Patch
M lily/slur.cc View 1 2 3 4 2 chunks +39 lines, -6 lines 0 comments Download

Messages

Total messages: 17
MikeSol
Hey all, I'm not sure if this patch will make a big difference, but it ...
7 years, 7 months ago (2011-11-24 09:39:53 UTC) #1
pkx166h
Passes make and reg test diff here http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2051-24-November-td4986583.html James
7 years, 7 months ago (2011-11-24 17:39:32 UTC) #2
Keith
I like the direction of this change. The code has your trademark incomprehensibility, so I ...
7 years, 7 months ago (2011-11-24 19:16:46 UTC) #3
mike_apollinemike.com
On Thu, 24 Nov 2011 19:16:46 +0000, k-ohara5a5a@oco.net wrote: > I like the direction of ...
7 years, 7 months ago (2011-11-25 05:01:39 UTC) #4
MikeSol
I've uploaded a new patch set where I've eliminated the 0.5 * height_limit. This will ...
7 years, 7 months ago (2011-11-25 06:10:50 UTC) #5
wl_gnu.org
>> The code has your trademark incomprehensibility, > > Thank you, Keith. You know, sometimes, ...
7 years, 7 months ago (2011-11-25 06:55:36 UTC) #6
pkx166h
passes make - reg test diffs attached here: http://code.google.com/p/lilypond/issues/detail?id=2051#c4 James
7 years, 7 months ago (2011-11-25 08:48:43 UTC) #7
pkx166h
Passes Make and reg tests are here http://code.google.com/p/lilypond/issues/detail?id=2051#c6 james
7 years, 7 months ago (2011-11-25 21:05:25 UTC) #8
Keith
On 2011/11/25 05:01:39, mike_apollinemike.com wrote: > On Thu, 24 Nov 2011 19:16:46 +0000, mailto:k-ohara5a5a@oco.net wrote: ...
7 years, 7 months ago (2011-11-26 01:42:33 UTC) #9
Keith
On 2011/11/26 01:42:33, Keith wrote: > On 2011/11/25 05:01:39, http://mike_apollinemike.com wrote: > > > > ...
7 years, 7 months ago (2011-11-26 02:08:07 UTC) #10
Keith
On 2011/11/26 01:42:33, Keith wrote: > On 2011/11/25 05:01:39, http://mike_apollinemike.com wrote: > > > > ...
7 years, 7 months ago (2011-11-26 02:09:57 UTC) #11
Keith
On 2011/11/26 02:09:57, Keith wrote: > Maybe the *0.5 was converting half-staff-spaces to staff-spaces No; ...
7 years, 7 months ago (2011-11-26 03:11:25 UTC) #12
pkx166h
Keith, retested. http://code.google.com/p/lilypond/issues/detail?id=2051#c9 passes make and a new set of reg test diffs are up. ...
7 years, 7 months ago (2011-11-26 08:38:50 UTC) #13
mike_apollinemike.com
On Nov 26, 2011, at 4:11 AM, k-ohara5a5a@oco.net wrote: > On 2011/11/26 02:09:57, Keith wrote: ...
7 years, 7 months ago (2011-11-26 18:15:42 UTC) #14
Keith
LGTM Removing the contribution from 'height-limit' to estimated slur heights is very helpful. It was ...
7 years, 7 months ago (2011-11-27 22:16:52 UTC) #15
mike_apollinemike.com
On Nov 27, 2011, at 11:16 PM, k-ohara5a5a@oco.net wrote: > LGTM > Removing the contribution ...
7 years, 7 months ago (2011-11-28 07:59:09 UTC) #16
pkx166h
7 years, 7 months ago (2011-11-28 18:01:53 UTC) #17
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b