Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(680)

Issue 5431056: Add EasyTracker Library

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by jjc
Modified:
1 month, 2 weeks ago
Reviewers:
nrhodes
CC:
analytics-api-samples-discuss_googlegroups.com
Base URL:
http://analytics-api-samples.googlecode.com/svn/trunk/src/tracking/mobile/android/
Visibility:
Public.

Patch Set 1 #

Total comments: 9

Patch Set 2 : Removed class files, updates to ReadMe.txt and build.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1397 lines, -0 lines) Patch
A EasyTracker/AndroidManifest.xml View 1 chunk +9 lines, -0 lines 0 comments Download
A EasyTracker/COPYING View 1 chunk +202 lines, -0 lines 0 comments Download
A EasyTracker/ReadMe.txt View 1 1 chunk +42 lines, -0 lines 0 comments Download
A EasyTracker/build.xml View 1 1 chunk +109 lines, -0 lines 0 comments Download
A EasyTracker/project.properties View 1 chunk +12 lines, -0 lines 0 comments Download
A EasyTracker/src/com/google/android/apps/analytics/easytracking/EasyTracker.java View 1 chunk +550 lines, -0 lines 0 comments Download
A EasyTracker/src/com/google/android/apps/analytics/easytracking/GoogleAnalyticsTrackerDelegate.java View 1 chunk +62 lines, -0 lines 0 comments Download
A EasyTracker/src/com/google/android/apps/analytics/easytracking/GoogleAnalyticsTrackerDelegateImpl.java View 1 chunk +106 lines, -0 lines 0 comments Download
A EasyTracker/src/com/google/android/apps/analytics/easytracking/ParameterLoader.java View 1 chunk +50 lines, -0 lines 0 comments Download
A EasyTracker/src/com/google/android/apps/analytics/easytracking/ParameterLoaderImpl.java View 1 chunk +87 lines, -0 lines 0 comments Download
A EasyTracker/src/com/google/android/apps/analytics/easytracking/TrackedActivity.java View 1 chunk +84 lines, -0 lines 0 comments Download
A EasyTracker/src/com/google/android/apps/analytics/easytracking/TrackedListActivity.java View 1 chunk +84 lines, -0 lines 0 comments Download

Messages

Total messages: 5
jjc
10 years, 5 months ago (2011-11-23 18:40:58 UTC) #1
nrhodes
And, of course, remove all .class files http://codereview.appspot.com/5431056/diff/1/EasyTracker/ReadMe.txt File EasyTracker/ReadMe.txt (right): http://codereview.appspot.com/5431056/diff/1/EasyTracker/ReadMe.txt#newcode3 EasyTracker/ReadMe.txt:3: version 1.0 ...
10 years, 5 months ago (2011-11-23 18:57:57 UTC) #2
jjc
10 years, 5 months ago (2011-11-23 19:18:13 UTC) #3
jjc
http://codereview.appspot.com/5431056/diff/1/EasyTracker/ReadMe.txt File EasyTracker/ReadMe.txt (right): http://codereview.appspot.com/5431056/diff/1/EasyTracker/ReadMe.txt#newcode3 EasyTracker/ReadMe.txt:3: version 1.0 On 2011/11/23 18:57:57, nrhodes wrote: > Version ...
10 years, 5 months ago (2011-11-23 19:18:34 UTC) #4
nrhodes
10 years, 5 months ago (2011-11-23 19:27:35 UTC) #5
LGTM

http://codereview.appspot.com/5431056/diff/1/EasyTracker/build.xml
File EasyTracker/build.xml (right):

http://codereview.appspot.com/5431056/diff/1/EasyTracker/build.xml#newcode21
EasyTracker/build.xml:21: GOOGLE_ANALYTICS environment variable to your Google
Analytics SDK's
Sounds good.
On 2011/11/23 19:18:34, jjc wrote:
> On 2011/11/23 18:57:57, nrhodes wrote:
> > Is this the jar file?
> 
> I reworded it.  Let me know if it makes more sense.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b