Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(91)

Issue 5414043: Uploading Bigquery example App Engine dashboard

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by lparkinson
Modified:
2 years, 4 months ago
Reviewers:
rmistry
Base URL:
https://google-api-java-client.googlecode.com/hg/
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added instructions to use client_secrets.json, removed my version. #

Patch Set 3 : And took out my client id/secret! #

Total comments: 1

Patch Set 4 : Removing unnecessary dependency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1430 lines, -0 lines) Patch
A bigquery-appengine-sample/.checkstyle View 1 chunk +7 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/.classpath View 1 chunk +9 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/.project View 1 chunk +39 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/.settings/com.google.appengine.eclipse.core.prefs View 1 chunk +4 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/.settings/com.google.gdt.eclipse.core.prefs View 1 chunk +5 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/.settings/com.google.gwt.eclipse.core.prefs View 1 chunk +4 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/.settings/org.eclipse.core.resources.prefs View 1 chunk +4 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/.settings/org.eclipse.jdt.core.prefs View 1 chunk +6 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/.settings/org.eclipse.ltk.core.refactoring.prefs View 1 chunk +3 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/.settings/org.eclipse.m2e.core.prefs View 1 chunk +5 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/instructions.html View 1 1 chunk +62 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/pom.xml View 1 2 3 1 chunk +105 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/src/main/java/com/google/api/client/sample/bigquery/appengine/dashboard/AuthServlet.java View 1 1 chunk +55 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/src/main/java/com/google/api/client/sample/bigquery/appengine/dashboard/AuthUtils.java View 1 1 chunk +126 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/src/main/java/com/google/api/client/sample/bigquery/appengine/dashboard/BigqueryUtils.java View 1 1 chunk +241 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/src/main/java/com/google/api/client/sample/bigquery/appengine/dashboard/DataServlet.java View 1 1 chunk +97 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/src/main/java/com/google/api/client/sample/bigquery/appengine/dashboard/DatastoreUtils.java View 1 1 chunk +154 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/src/main/java/com/google/api/client/sample/bigquery/appengine/dashboard/DeniedAuth.java View 1 1 chunk +26 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/src/main/java/com/google/api/client/sample/bigquery/appengine/dashboard/MainServlet.java View 1 1 chunk +102 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/src/main/java/com/google/api/client/sample/bigquery/appengine/dashboard/OAuth2Callback.java View 1 1 chunk +46 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/src/main/java/com/google/api/client/sample/bigquery/appengine/dashboard/SampleDashboardException.java View 1 1 chunk +43 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/src/main/java/com/google/api/client/sample/bigquery/appengine/dashboard/TaskServlet.java View 1 1 chunk +87 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/src/main/resources/META-INF/jdoconfig.xml View 1 1 chunk +15 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/src/main/webapp/WEB-INF/appengine-web.xml View 1 1 chunk +31 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/src/main/webapp/WEB-INF/logging.properties View 1 1 chunk +13 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/src/main/webapp/WEB-INF/web.xml View 1 1 chunk +81 lines, -0 lines 0 comments Download
A bigquery-appengine-sample/src/main/webapp/drawGraph.js View 1 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 8
lparkinson
2 years, 5 months ago #1
rmistry
http://codereview.appspot.com/5414043/diff/1/bigquery-appengine-sample/src/main/resources/client_secrets.json File bigquery-appengine-sample/src/main/resources/client_secrets.json (right): http://codereview.appspot.com/5414043/diff/1/bigquery-appengine-sample/src/main/resources/client_secrets.json#newcode1 bigquery-appengine-sample/src/main/resources/client_secrets.json:1: { In the samples repository we have client_secrets.json files ...
2 years, 4 months ago #2
rmistry
http://codereview.appspot.com/5414043/diff/1/bigquery-appengine-sample/src/main/resources/client_secrets.json File bigquery-appengine-sample/src/main/resources/client_secrets.json (right): http://codereview.appspot.com/5414043/diff/1/bigquery-appengine-sample/src/main/resources/client_secrets.json#newcode1 bigquery-appengine-sample/src/main/resources/client_secrets.json:1: { On 2011/11/20 16:03:42, rmistry wrote: > In the ...
2 years, 4 months ago #3
lparkinson
2 years, 4 months ago #4
lparkinson
2 years, 4 months ago #5
rmistry
http://codereview.appspot.com/5414043/diff/9001/bigquery-appengine-sample/pom.xml File bigquery-appengine-sample/pom.xml (right): http://codereview.appspot.com/5414043/diff/9001/bigquery-appengine-sample/pom.xml#newcode86 bigquery-appengine-sample/pom.xml:86: <artifactId>shared-sample-gdata</artifactId> Do you need this dependency?
2 years, 4 months ago #6
lparkinson
2 years, 4 months ago #7
rmistry
2 years, 4 months ago #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1274:9b9295c7fd64