Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(380)

Issue 5412051: Add \accidentalStyle command (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by dak
Modified:
7 years, 7 months ago
Reviewers:
pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add \accidentalStyle command Also adds conversion rules. If you want to check the results of the conversion by running scripts/auxiliar/update-with-convert-ly.sh you will need to have VERSION giving a PATCH_LEVEL of at least 20 (nudge, nudge, wink, wink) before testing. The convert rule goes with the syntax \accidentalStyle "default" rather than the also permitted \accidentalStyle #'default based on the premise that user-level commands should preferably not require calling Scheme. The optional context argument of set-accidental-style is not supported. Taking a look at the converted examples, knowledge that set-accidental-style makes its changes at StaffGroup or GrandStaff level by default does not seem all too wide-spread: more often than not, it is called in every Staff context of a group.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M ly/property-init.ly View 1 chunk +7 lines, -0 lines 0 comments Download
M python/convertrules.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 1
pkx166h
7 years, 7 months ago (2011-11-20 07:52:45 UTC) #1
passes make and make check.

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b