Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(243)

Issue 5361042: avoid cryptic StopIteration failure from make when 'make check' is run before 'make test-baseline' (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by adam.spiers
Modified:
7 years, 7 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

avoid cryptic StopIteration failure from make when 'make check' is run before 'make test-baseline'

Patch Set 1 #

Total comments: 1

Patch Set 2 : New version with modified diagnostics text to keep Ian happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M scripts/build/output-distance.py View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 7
adam.spiers
This one should be pretty self-explanatory. Hopefully it will prevent anyone in the future wasting ...
7 years, 7 months ago (2011-11-05 23:50:07 UTC) #1
Ian Hulin (gmail)
LGTM apart from the way the error messages are phrased. Cheers, Ian http://codereview.appspot.com/5361042/diff/1/scripts/build/output-distance.py File scripts/build/output-distance.py ...
7 years, 7 months ago (2011-11-06 19:27:55 UTC) #2
adam.spiers
I disagree - there is no way to be sure that the cause of the ...
7 years, 7 months ago (2011-11-06 21:30:18 UTC) #3
Ian Hulin (gmail)
On 2011/11/06 21:30:18, adam.spiers wrote: > I disagree - there is no way to be ...
7 years, 7 months ago (2011-11-07 17:41:21 UTC) #4
adam.spiers
New version attached.
7 years, 7 months ago (2011-11-07 19:17:15 UTC) #5
pkx166h
Passes Make and no reg test diffs. James
7 years, 7 months ago (2011-11-07 20:50:56 UTC) #6
adam.spiers
7 years, 7 months ago (2011-11-28 21:22:41 UTC) #7
Pushed to staging as 46081ce4
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b