Issue 53490043: ensure that observedSet resets observed objects after changes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 53490043: ensure that observedSet resets observed objects after changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by rafaelw

Modified:
10 years, 3 months ago

Reviewers:
arv

Base URL:
https://github.com/Polymer/observe-js.git@master

Visibility:
Public.

More Reviews

Description

ensure that observedSet resets observed objects after changes this was a pretty major oversight on my part, and unfortunately, the tests are structure such that the "organic" callback of Object.observe is never depended upon. What really needs to be done here is to make most of the tests be async using the then() pattern, but this bug is blocking polymer release, so I'm going to do that work in a follow-on patch. https://github.com/Polymer/observe-js/issues/42 R=arv BUG= Committed: https://github.com/Polymer/observe-js/commit/0152d54

Patch Set 1 #

Patch Set 2 : fix for dirty-check mode #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -4 lines)			Patch
	M	src/observe.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	tests/test.js	View	1	4 chunks	+39 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #2 manually as r0152d54 (presubmit successful).

10 years, 3 months ago (2014-01-16 23:49:39 UTC) #1

Message was sent while issue was closed.

LGTM

Expand All Messages | Collapse All Messages