Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1645)

Issue 5342042: Improve HTML output of regression tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by adam.spiers
Modified:
7 years, 7 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Improve HTML output of regression tests - Use Javascript to enable filtering of table rows by type - Make sure git file compare cell contents are HTML-escaped - Fix some HTML validation issues

Patch Set 1 #

Total comments: 6

Patch Set 2 : New version which addresses Julien's points #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -13 lines) Patch
M scripts/build/output-distance.py View 1 4 chunks +52 lines, -13 lines 0 comments Download

Messages

Total messages: 9
adam.spiers
As previously discussed, here are some improvements to the generation of build/out/test-results/index.html. In particular, you ...
7 years, 7 months ago (2011-11-04 16:06:21 UTC) #1
pkx166h
passes make and no reg test diffs. James
7 years, 7 months ago (2011-11-04 22:36:02 UTC) #2
Graham Percival
http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py File scripts/build/output-distance.py (right): http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode1304 scripts/build/output-distance.py:1304: if len (args) % 2 == 1: why is ...
7 years, 7 months ago (2011-11-07 08:52:52 UTC) #3
dak
http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py File scripts/build/output-distance.py (right): http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode1304 scripts/build/output-distance.py:1304: if len (args) % 2 == 1: On 2011/11/07 ...
7 years, 7 months ago (2011-11-07 09:15:04 UTC) #4
adam.spiers
On 2011/11/07 09:15:04, dak wrote: > Uh, yes? See line 1313: the argument list consists ...
7 years, 7 months ago (2011-11-07 09:58:05 UTC) #5
Julien Rioux
Only stylistic comments: http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py File scripts/build/output-distance.py (right): http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode8 scripts/build/output-distance.py:8: from cgi import escape Since the ...
7 years, 7 months ago (2011-11-07 15:53:48 UTC) #6
adam.spiers
New patch set uploaded. http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py File scripts/build/output-distance.py (right): http://codereview.appspot.com/5342042/diff/1/scripts/build/output-distance.py#newcode8 scripts/build/output-distance.py:8: from cgi import escape On ...
7 years, 7 months ago (2011-11-07 19:20:42 UTC) #7
pkx166h
passes make and no reg test diffs. james
7 years, 7 months ago (2011-11-07 20:56:39 UTC) #8
adam.spiers
7 years, 7 months ago (2011-11-28 21:21:54 UTC) #9
Pushed to staging as 1294535b
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b