Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 5341049: Issue 2024: Let #{ ... #} pass its $ handling to environment cloning (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by dak
Modified:
7 years, 10 months ago
Reviewers:
pkx166h, wl, carl.d.sorensen, Trevor Daniels, c_sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 2024: Let #{ ... #} pass its $ handling to environment cloning Consists of the patches: Adapt docs to new $ and #{ ... #} behavior Run scripts/auxiliar/update-with-convert-ly.sh Let #{ ... #} pass its $ handling to environment cloning Includes convertrules.py rules Permit ly:parser-clone to receive an environment lexer.ll: add $ for immediate export. Purpose is to make $ generally available rather than to have it just in #{ ... #}, let it completely replace the need for ly:export, and to let #{ ... #} import its lexical environment into its embedded Scheme expressions via # or $. Unfortunately, you will likely have to bump PATCHLEVEL in VERSION manually for testing, as dev/staging is still locked at 2.15.17 which is too small after running convert-ly.

Patch Set 1 #

Patch Set 2 : This removes all uses of ly:export via convert-ly. Bump VERSION before testing. #

Total comments: 3

Patch Set 3 : Rebase on current dev/staging, no change in content. #

Patch Set 4 : Ran convert-ly on scm/*.scm, just a single character changed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+545 lines, -525 lines) Patch
M Documentation/cs/usage/running.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/de/extending/scheme-tutorial.itely View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/de/notation/pitches.itely View 1 23 chunks +40 lines, -40 lines 0 comments Download
M Documentation/de/notation/rhythms.itely View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/de/usage/running.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/es/extending/programming-interface.itely View 4 chunks +6 lines, -6 lines 0 comments Download
M Documentation/es/extending/scheme-tutorial.itely View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/es/notation/pitches.itely View 1 24 chunks +41 lines, -41 lines 0 comments Download
M Documentation/es/notation/rhythms.itely View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/es/usage/running.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/extending/programming-interface.itely View 1 2 5 chunks +15 lines, -37 lines 0 comments Download
M Documentation/extending/scheme-tutorial.itely View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/fr/notation/pitches.itely View 1 23 chunks +40 lines, -40 lines 0 comments Download
M Documentation/fr/notation/rhythms.itely View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/fr/usage/running.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/hu/learning/fundamental.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/hu/usage/running.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/it/usage/running.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ja/notation/pitches.itely View 1 23 chunks +40 lines, -40 lines 0 comments Download
M Documentation/ja/notation/rhythms.itely View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/ja/usage/running.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ly-examples/aucun-snippet.ly View 3 chunks +13 lines, -13 lines 0 comments Download
M Documentation/ly-examples/bach-bwv610.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ly-examples/cary-layout.ily View 2 chunks +5 lines, -5 lines 0 comments Download
M Documentation/notation/pitches.itely View 1 23 chunks +40 lines, -40 lines 0 comments Download
M Documentation/notation/rhythms.itely View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/snippets/adding-orchestral-cues-to-a-vocal-score.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/arabic-improvisation.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/center-text-below-hairpin-dynamics.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/chords-headword.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/conducting-signs,-measure-grouping-signs.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/fretted-headword.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/generating-random-notes.ly View 1 3 chunks +4 lines, -5 lines 0 comments Download
M Documentation/snippets/heavily-customized-polymetric-time-signatures.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/incipit.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/new/chords-headword.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/new/fretted-headword.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/new/incipit.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/new/score-for-diatonic-accordion.ly View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Documentation/snippets/score-for-diatonic-accordion.ly View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Documentation/snippets/tweaking-grace-layout-within-music.ly View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/usage/running.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/accidental-contemporary.ly View 1 2 chunks +5 lines, -5 lines 0 comments Download
M input/regression/accidental-piano.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/accidental-voice.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/baerenreiter-sarabande.ly View 1 3 chunks +5 lines, -5 lines 0 comments Download
M input/regression/display-lily-tests.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/flags-straight-stockhausen-boulez.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/lily-in-scheme.ly View 1 chunk +4 lines, -4 lines 0 comments Download
M input/regression/markup-scheme.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/measure-grouping.ly View 1 2 chunks +4 lines, -4 lines 0 comments Download
M input/regression/mensural-ligatures.ly View 1 3 chunks +3 lines, -3 lines 0 comments Download
M input/regression/metronome-range.ly View 1 2 chunks +3 lines, -4 lines 0 comments Download
M input/regression/metronome-text.ly View 1 2 chunks +3 lines, -4 lines 0 comments Download
M input/regression/morgenlied.ly View 1 4 chunks +4 lines, -4 lines 0 comments Download
M input/regression/mozart-hrn-3.ly View 1 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/page-breaks.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/rest-ledger.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/spacing-accidental-stretch.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/typography-demo.ly View 1 4 chunks +4 lines, -4 lines 0 comments Download
M lily/include/lily-lexer.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/lily-parser.hh View 1 chunk +2 lines, -1 line 0 comments Download
M lily/lexer.ll View 1 2 4 chunks +43 lines, -14 lines 0 comments Download
M lily/lily-parser.cc View 3 chunks +4 lines, -1 line 0 comments Download
M lily/lily-parser-scheme.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/parse-scm.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ly/bagpipe.ly View 1 3 chunks +4 lines, -4 lines 0 comments Download
M ly/chord-modifiers-init.ly View 1 3 chunks +6 lines, -6 lines 0 comments Download
M ly/engraver-init.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ly/music-functions-init.ly View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M ly/spanners-init.ly View 1 2 chunks +5 lines, -5 lines 0 comments Download
M ly/titling-init.ly View 1 2 chunks +3 lines, -4 lines 0 comments Download
M python/convertrules.py View 1 1 chunk +59 lines, -0 lines 0 comments Download
M scm/define-music-display-methods.scm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M scm/music-functions.scm View 1 6 chunks +7 lines, -9 lines 0 comments Download
M scm/parser-ly-from-scheme.scm View 1 chunk +21 lines, -68 lines 0 comments Download

Messages

Total messages: 9
Trevor Daniels
I don't claim to understand much of this, but the resulting simplification seems worth the ...
7 years, 10 months ago (2011-11-08 16:37:25 UTC) #1
dak
On 2011/11/08 16:37:25, Trevor Daniels wrote: > I don't claim to understand much of this, ...
7 years, 10 months ago (2011-11-08 17:24:03 UTC) #2
Carl
I *really* like this change. It simplifies and clarifies things tremendously. Some time ago, Han-Wen ...
7 years, 10 months ago (2011-11-08 17:46:10 UTC) #3
wl_gnu.org
>> I don't claim to understand much of this, but the resulting >> simplification seems ...
7 years, 10 months ago (2011-11-08 18:44:53 UTC) #4
pkx166h
This didn't pass 'make'. Not sure if it is JUST the version number (not sure ...
7 years, 10 months ago (2011-11-08 21:04:34 UTC) #5
c_sorensen
On 11/8/11 2:04 PM, "pkx166h@gmail.com" <pkx166h@gmail.com> wrote: >This didn't pass 'make'. Not sure if it ...
7 years, 10 months ago (2011-11-08 21:49:19 UTC) #6
dak
Carl Sorensen <c_sorensen@byu.edu> writes: > On 11/8/11 2:04 PM, "pkx166h@gmail.com" <pkx166h@gmail.com> wrote: > >>This didn't ...
7 years, 10 months ago (2011-11-08 21:50:54 UTC) #7
pkx166h
Passes make and there are no pictorial reg test diffs but the 'textural' test results ...
7 years, 10 months ago (2011-11-08 22:06:28 UTC) #8
c_sorensen
7 years, 10 months ago (2011-11-08 22:06:57 UTC) #9

On 11/8/11 2:50 PM, "David Kastrup" <dak@gnu.org> wrote:

>Carl Sorensen <c_sorensen@byu.edu> writes:
>
>> On 11/8/11 2:04 PM, "pkx166h@gmail.com" <pkx166h@gmail.com> wrote:
>>
>>>This didn't pass 'make'. Not sure if it is JUST the version number (not
>>>sure how to test this patch otherwise) or if there is an additional
>>>problem. I can also do a full make doc when it passes make.
>>>
>>
>> Edit the file VERSION in the home directory, so that the PATCH_LEVEL
>>entry
>> says
>>
>> PATCH_LEVEL=17
>>
>>
>> This should fix the error you listed.
>
>18, I should think.

Yep, absolutely.   I hate typos.  I need to proofread things better....

Carl

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b