Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(300)

Issue 5322065: Implement \once as music function able to operate on complex stuff. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by dak
Modified:
7 years, 7 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Implement \once as music function able to operate on complex stuff.

Patch Set 1 #

Patch Set 2 : Add regtest. #

Total comments: 7

Patch Set 3 : Address Neil's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
A input/regression/complex-once.ly View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M lily/lily-lexer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M lily/parser.yy View 2 chunks +1 line, -5 lines 0 comments Download
M ly/music-functions-init.ly View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M scm/ly-syntax-constructors.scm View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8
Reinhold
LGTM, although regtests are missing (for \once applied to multiple settings at one, stored in ...
7 years, 7 months ago (2011-11-03 10:47:59 UTC) #1
dak
On 2011/11/03 10:47:59, Reinhold wrote: > LGTM, although regtests are missing (for \once applied to ...
7 years, 7 months ago (2011-11-03 11:25:49 UTC) #2
Reinhold
http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly File input/regression/complex-once.ly (right): http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly#newcode11 input/regression/complex-once.ly:11: \unHideNotes g a \once\hideNotes b c | While this ...
7 years, 7 months ago (2011-11-03 11:45:00 UTC) #3
dak
On 2011/11/03 11:45:00, Reinhold wrote: > http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly > File input/regression/complex-once.ly (right): > > http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly#newcode11 > ...
7 years, 7 months ago (2011-11-03 12:57:26 UTC) #4
dak
As an illustration: take a look at ly/property-init.ly. It contains dozens of commands that will ...
7 years, 7 months ago (2011-11-03 14:15:33 UTC) #5
Neil Puttock
LGTM. http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly File input/regression/complex-once.ly (right): http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly#newcode7 input/regression/complex-once.ly:7: \layout { ragged-right = ##t } redundant http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly#newcode11 ...
7 years, 7 months ago (2011-11-03 14:21:05 UTC) #6
dak
http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly File input/regression/complex-once.ly (right): http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly#newcode7 input/regression/complex-once.ly:7: \layout { ragged-right = ##t } On 2011/11/03 14:21:05, ...
7 years, 7 months ago (2011-11-03 14:47:54 UTC) #7
pkx166h
7 years, 7 months ago (2011-11-03 23:42:09 UTC) #8
Passes make and no reg test diffs.

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b