Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(497)

Issue 5306076: changing-defaults.itely: correct misstatement about variables for context mods (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by dak
Modified:
7 years, 7 months ago
Reviewers:
pkx166h, Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

changing-defaults.itely: correct misstatement about variables for context mods

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed James' comments. Should not disturb countdown. #

Total comments: 3

Patch Set 3 : Remove suggested section. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M Documentation/notation/changing-defaults.itely View 1 2 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 6
pkx166h
Some Doc policy nit-picks http://codereview.appspot.com/5306076/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/5306076/diff/1/Documentation/notation/changing-defaults.itely#newcode727 Documentation/notation/changing-defaults.itely:727: You may collect context changes ...
7 years, 8 months ago (2011-10-29 16:23:44 UTC) #1
dak
Review addressed. Changes are trivial enough that countdown can continue.
7 years, 7 months ago (2011-11-01 14:12:43 UTC) #2
Neil Puttock
http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (left): http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changing-defaults.itely#oldcode732 Documentation/notation/changing-defaults.itely:732: The @code{\Staff \RemoveEmptyStaves} will overwrite your current This knownissue ...
7 years, 7 months ago (2011-11-03 12:27:33 UTC) #3
dak
http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (left): http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changing-defaults.itely#oldcode732 Documentation/notation/changing-defaults.itely:732: The @code{\Staff \RemoveEmptyStaves} will overwrite your current On 2011/11/03 ...
7 years, 7 months ago (2011-11-03 13:05:20 UTC) #4
pkx166h
http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (left): http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changing-defaults.itely#oldcode732 Documentation/notation/changing-defaults.itely:732: The @code{\Staff \RemoveEmptyStaves} will overwrite your current On 2011/11/03 ...
7 years, 7 months ago (2011-11-03 13:15:23 UTC) #5
dak
7 years, 7 months ago (2011-11-03 13:48:21 UTC) #6
On 2011/11/03 13:15:23, J_lowe wrote:
>
http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changi...
> File Documentation/notation/changing-defaults.itely (left):
> 
>
http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changi...
> Documentation/notation/changing-defaults.itely:732: The @code{\Staff
> \RemoveEmptyStaves} will overwrite your current
> On 2011/11/03 13:05:21, dak wrote:
> > On 2011/11/03 12:27:33, Neil Puttock wrote:
> > > This knownissue no longer applies.
> > 
> > Not exactly my fault.  Since I have no clue how much material needs to get
> > removed here, and whether it needs to be replaced by something else, I
prefer
> > leaving that change to someone else.
> > 
> > I don't see a reason why this should block my patch: surely correcting one
> error
> > is better than correcting none.
> 
> Can you just remove everything between
> 
> @knownissues all the way down to (but not including) @c TODO when you push?
> 
> I don't think that would be a big deal.
> 
> James

Pushed something to dev/staging doing that.  This should teach me to do "fast
fixes".
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b