Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(217)

Issue 5306050: Adds Scheme function for spring constructor. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by MikeSol
Modified:
7 years, 8 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Adds Scheme function for spring constructor.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Setters for compress and stretch strength. #

Total comments: 7

Patch Set 3 : Incorporates proposed changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M lily/spring-smob.cc View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
M scm/lily.scm View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8
Bertrand Bordage
LGTM.
7 years, 8 months ago (2011-10-21 10:04:44 UTC) #1
Neil Puttock
http://codereview.appspot.com/5306050/diff/1/lily/spring-smob.cc File lily/spring-smob.cc (right): http://codereview.appspot.com/5306050/diff/1/lily/spring-smob.cc#newcode48 lily/spring-smob.cc:48: "spring, and @code{min-dist} is the minimum distance.") @var{min-dist} http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc ...
7 years, 8 months ago (2011-10-21 11:18:06 UTC) #2
dak
http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc File lily/spring-smob.cc (left): http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42 lily/spring-smob.cc:42: return a == b ? SCM_BOOL_T : SCM_BOOL_F; On ...
7 years, 8 months ago (2011-10-21 11:27:34 UTC) #3
dak
On 2011/10/21 11:27:34, dak wrote: > http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc > File lily/spring-smob.cc (left): > > http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42 > ...
7 years, 8 months ago (2011-10-21 11:34:01 UTC) #4
Bertrand Bordage
http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc File lily/spring-smob.cc (left): http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42 lily/spring-smob.cc:42: return a == b ? SCM_BOOL_T : SCM_BOOL_F; On ...
7 years, 8 months ago (2011-10-21 11:39:41 UTC) #5
dak
On 2011/10/21 11:39:41, Bertrand Bordage wrote: > http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc > File lily/spring-smob.cc (left): > > http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42 ...
7 years, 8 months ago (2011-10-21 11:43:10 UTC) #6
Neil Puttock
On 21 October 2011 12:39, <bordage.bertrand@gmail.com> wrote: > For me, this function is totally useless. ...
7 years, 8 months ago (2011-10-21 11:50:22 UTC) #7
MikeSol
7 years, 8 months ago (2011-10-23 10:33:39 UTC) #8
Hey all,

I've made all of the requested changes save Spring::equal_p, as I can't see a
clear consensus about what changes need to be made here.  As this problem is
outside the purview of this patch, it may be worth it to propose another patch
that treats this issue (and others like it in other smobs if such issues exist)
separately.

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b