Issue 5305041: Rename to libpyzy and remove unused files.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5305041: Rename to libpyzy and remove unused files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by hsumita

Modified:
12 years, 6 months ago

Reviewers:
shawn.p.huang, penghuang, Peng

CC:
komatsu, mukai, yusukes, nona, horo

Base URL:
git@github.com:hsumita/libpyzy.git@master

Visibility:
Public.

Description

Rename to libpyzy and remove unused files. This CL don't modify some files which is related to a URL or debian. BUG=None TEST=Manually

Patch Set 2 : Remove koterpillar from AUTHORS. #

Total comments: 4

Patch Set 3 : Add an author and remove a needless line. #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -575 lines)			Patch
M	.gitignore	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	AUTHORS	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download
M	Makefile.am	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	autogen.sh	View		1 chunk	+1 line, -1 line	0 comments	Download
M	configure.ac	View	1 2	3 chunks	+2 lines, -10 lines	0 comments	Download
D	ibus-pinyin.spec.in	View		1 chunk	+0 lines, -99 lines	0 comments	Download
A +	libpyzy.spec.in	View		3 chunks	+11 lines, -14 lines	0 comments	Download
M	src/.gitignore	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/Makefile.am	View	1 2	4 chunks	+0 lines, -19 lines	0 comments	Download
D	src/Makefile.am.lib	View		1 chunk	+0 lines, -193 lines	0 comments	Download
D	src/Makefile.am.test	View		1 chunk	+0 lines, -186 lines	0 comments	Download
D	src/pinyin.xml.in.in	View		1 chunk	+0 lines, -42 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

http://codereview.appspot.com/5305041/diff/1012/AUTHORS File AUTHORS (right): http://codereview.appspot.com/5305041/diff/1012/AUTHORS#newcode3 AUTHORS:3: Peng Wu <alexepico@gmail.com> Add you as an author. http://codereview.appspot.com/5305041/diff/1012/configure.ac ...

12 years, 6 months ago (2011-10-18 14:32:27 UTC) #1

hsumita

12 years, 6 months ago (2011-10-19 04:34:56 UTC) #2

Peng

12 years, 6 months ago (2011-10-19 13:42:38 UTC) #3

On 2011/10/19 04:34:56, hsumita wrote:
> http://codereview.appspot.com/5305041/diff/1012/AUTHORS
> File AUTHORS (right):
> 
> http://codereview.appspot.com/5305041/diff/1012/AUTHORS#newcode3
> AUTHORS:3: Peng Wu <mailto:alexepico@gmail.com>
> On 2011/10/18 14:32:27, Peng wrote:
> > Add you as an author.
> 
> Done.
> 
> http://codereview.appspot.com/5305041/diff/1012/configure.ac
> File configure.ac (right):
> 
> http://codereview.appspot.com/5305041/diff/1012/configure.ac#newcode36
> configure.ac:36: AC_CONFIG_SRCDIR([src/PyZyInputContext.h])
> On 2011/10/18 14:32:27, Peng wrote:
> > What is it for?
> 
> Done.

lgtm

Expand All Messages | Collapse All Messages