Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1828)

Issue 5298050: Allow more argument types, interpret optional argument predicates syntactically. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by dak
Modified:
7 years, 8 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Allow more argument types, interpret optional argument predicates syntactically. This is a patch series also available as the dev/syntax branch instead of a big patch. It is intended for timely inclusion into Lilypond. The patches are: parser.yy: Allow a few more syntactic classes for Scheme arguments programming-interface.itely: explain extended function argument semantics parser.yy: Allow markups, markup lists, and context modifications as Scheme arguments Add regtest for skipping optional arguments via predicate. parser.yy: allow optional Scheme arguments to be skipped based on the predicate. parser.yy: allow music rather than closed_music in connection with lyrics parser.yy: let closed_music accept a few complex forms parser: change order of arguments for context-specification constructor parser.yy et al: move functionality of run_music_function into syntax constructor

Patch Set 1 #

Patch Set 2 : Fix a small cut&paste oversight #

Patch Set 3 : Fix confusing toplevel behavior by too permissive \addlyrics #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -107 lines) Patch
M Documentation/extending/programming-interface.itely View 1 chunk +10 lines, -9 lines 0 comments Download
A input/regression/optional-args-predicate.ly View 1 chunk +20 lines, -0 lines 0 comments Download
M lily/lexer.ll View 1 chunk +0 lines, -2 lines 0 comments Download
M lily/parser.yy View 1 2 26 chunks +125 lines, -92 lines 0 comments Download
M scm/ly-syntax-constructors.scm View 3 chunks +7 lines, -4 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b