Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1610)

Issue 52460043: Fixed juju test load point and destroy-environment

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by Marco Ceppi
Modified:
10 years, 2 months ago
Reviewers:
mp+201694, benjamin.saller
Visibility:
Public.

Description

Fixed juju test load point and destroy-environment https://code.launchpad.net/~marcoceppi/charm-tools/fix-juju-test/+merge/201694 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed juju test load point and destroy-environment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M charmtools/test.py View 4 chunks +11 lines, -3 lines 0 comments Download
M setup.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/test_juju_test.py View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 3
Marco Ceppi
Please take a look.
10 years, 2 months ago (2014-01-15 00:21:06 UTC) #1
benjamin.saller
LGTM Thanks for getting these fixes in. https://codereview.appspot.com/52460043/diff/1/charmtools/test.py File charmtools/test.py (right): https://codereview.appspot.com/52460043/diff/1/charmtools/test.py#newcode634 charmtools/test.py:634: test_cfg = ...
10 years, 2 months ago (2014-01-15 02:06:19 UTC) #2
Marco Ceppi
10 years, 2 months ago (2014-01-15 18:50:57 UTC) #3
*** Submitted:

Fixed juju test load point and destroy-environment

R=benjamin.saller
CC=
https://codereview.appspot.com/52460043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b