Issue 5240054: CG: clarify git-cl and contributor quick start

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5240054: CG: clarify git-cl and contributor quick start

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by Graham Percival (old account)

Modified:
12 years, 6 months ago

Reviewers:
Bertrand Bordage

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

CG: clarify git-cl and contributor quick start

Patch Set 2 : clarify #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -12 lines)			Patch
	M	Documentation/contributor/quick-start.itexi	View		2 chunks	+1 line, -8 lines	0 comments	Download
	M	Documentation/contributor/source-code.itexi	View	1	3 chunks	+14 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Graham Percival (old account)

Patchy the autobot will ok this in an hour or so, but please take a ...

12 years, 6 months ago (2011-10-11 17:33:41 UTC) #1

Bertrand Bordage

LGTM http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right): http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source-code.itexi#newcode953 Documentation/contributor/source-code.itexi:953: Note that a google account need not be ...

12 years, 6 months ago (2011-10-11 17:34:43 UTC) #2

Graham Percival (old account)

12 years, 6 months ago (2011-10-11 17:39:08 UTC) #3

http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source...
File Documentation/contributor/source-code.itexi (right):

http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source...
Documentation/contributor/source-code.itexi:953: Note that a google account need
not be a gmail account; you can
On 2011/10/11 17:34:43, Bertrand Bordage wrote:
> "doesn't need to be a gmail account"?

My version was not incorrect by the rules of formal English grammar, but it
could certainly sound weird to non-native speakers.  I've made the change you
suggested, thanks!

Expand All Messages | Collapse All Messages