Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 5240054: CG: clarify git-cl and contributor quick start

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by Graham Percival (old account)
Modified:
7 years, 9 months ago
Reviewers:
Bertrand Bordage
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

CG: clarify git-cl and contributor quick start

Patch Set 1 #

Total comments: 2

Patch Set 2 : clarify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M Documentation/contributor/quick-start.itexi View 2 chunks +1 line, -8 lines 0 comments Download
M Documentation/contributor/source-code.itexi View 1 3 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 3
Graham Percival (old account)
Patchy the autobot will ok this in an hour or so, but please take a ...
7 years, 9 months ago (2011-10-11 17:33:41 UTC) #1
Bertrand Bordage
LGTM http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right): http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source-code.itexi#newcode953 Documentation/contributor/source-code.itexi:953: Note that a google account need not be ...
7 years, 9 months ago (2011-10-11 17:34:43 UTC) #2
Graham Percival (old account)
7 years, 9 months ago (2011-10-11 17:39:08 UTC) #3
http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source...
File Documentation/contributor/source-code.itexi (right):

http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source...
Documentation/contributor/source-code.itexi:953: Note that a google account need
not be a gmail account; you can
On 2011/10/11 17:34:43, Bertrand Bordage wrote:
> "doesn't need to be a gmail account"?

My version was not incorrect by the rules of formal English grammar, but it
could certainly sound weird to non-native speakers.  I've made the change you
suggested, thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b