Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20)

Issue 5235052: First stab at getting script offsets right. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by MikeSol
Modified:
7 years, 8 months ago
Reviewers:
mike, Bertrand Bordage, dak, Neil Puttock, wl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

First stab at getting script offsets right.

Patch Set 1 #

Patch Set 2 : Fixes circular dependency. #

Patch Set 3 : Adds regtest. #

Patch Set 4 : Fixes problem in tablature regtests #

Patch Set 5 : Fixes infinity values for quote voices #

Total comments: 2

Patch Set 6 : Issue 1951 - more precise script positioning over accidentals. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -26 lines) Patch
A input/regression/script-accidental-collision.ly View 1 2 3 4 5 1 chunk +21 lines, -0 lines 0 comments Download
M lily/box.cc View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M lily/grob.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M lily/include/box.hh View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/side-position-interface.hh View 1 chunk +2 lines, -0 lines 0 comments Download
M lily/script-engraver.cc View 1 3 chunks +13 lines, -0 lines 2 comments Download
M lily/side-position-interface.cc View 1 2 3 4 5 7 chunks +129 lines, -23 lines 0 comments Download
M lily/slur.cc View 1 2 3 4 1 chunk +5 lines, -0 lines 1 comment Download
M scm/define-grob-properties.scm View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M scm/define-grobs.scm View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12
MikeSol
Hey all, This patch fixes issue 1951 but causes other problems (check out accidental-suggestions.ly). Does ...
7 years, 9 months ago (2011-10-09 19:29:00 UTC) #1
mike_apollinemike.com
On Oct 9, 2011, at 9:29 PM, mtsolo@gmail.com wrote: > Reviewers: , > > Message: ...
7 years, 9 months ago (2011-10-09 19:53:39 UTC) #2
MikeSol
Hey all, The newest patchset adds a debug function to bug.cc. I'd push it as ...
7 years, 9 months ago (2011-10-10 07:15:35 UTC) #3
dak
On 2011/10/10 07:15:35, MikeSol wrote: > The newest patchset adds a debug function to bug.cc. ...
7 years, 9 months ago (2011-10-10 07:26:23 UTC) #4
mike_apollinemike.com
On Oct 10, 2011, at 9:26 AM, dak@gnu.org wrote: > On 2011/10/10 07:15:35, MikeSol wrote: ...
7 years, 9 months ago (2011-10-10 07:40:24 UTC) #5
dak
On 2011/10/10 07:40:24, mike_apollinemike.com wrote: > Yes'r. I think that this will be useful in ...
7 years, 9 months ago (2011-10-10 08:01:40 UTC) #6
Neil Puttock
http://codereview.appspot.com/5235052/diff/17001/lily/script-engraver.cc File lily/script-engraver.cc (right): http://codereview.appspot.com/5235052/diff/17001/lily/script-engraver.cc#newcode206 lily/script-engraver.cc:206: Script_engraver::acknowledge_inline_accidental (Grob_info info) Doesn't this add every accidental to ...
7 years, 9 months ago (2011-10-18 13:56:34 UTC) #7
mike_apollinemike.com
On Oct 18, 2011, at 3:56 PM, n.puttock@gmail.com wrote: > > http://codereview.appspot.com/5235052/diff/17001/lily/script-engraver.cc > File lily/script-engraver.cc ...
7 years, 9 months ago (2011-10-19 08:05:34 UTC) #8
Bertrand Bordage
LGTM, but the result is really disturbing. We need to think about a better approach ...
7 years, 8 months ago (2011-10-21 01:41:27 UTC) #9
mike_apollinemike.com
On Oct 21, 2011, at 3:41 AM, bordage.bertrand@gmail.com wrote: > LGTM, but the result is ...
7 years, 8 months ago (2011-10-21 06:48:22 UTC) #10
wl_gnu.org
>> [...] We need to think about a better approach of character boxes >> in ...
7 years, 8 months ago (2011-10-21 10:37:40 UTC) #11
Bertrand Bordage
7 years, 8 months ago (2011-10-21 10:48:33 UTC) #12
Of course.  But I meant "it's impossible to interpret a mask that would be a
MetaFont glyph".
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b