Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1765)

Issue 5233042: Optimizes note-heads.cc and introduces robust_symbol2string. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by Bertrand Bordage
Modified:
7 years, 8 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Optimizes note-heads.cc and introduces robust_symbol2string. Potential fix to issue 1926.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove one glyph lookup. #

Total comments: 2

Patch Set 3 : Restore a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -76 lines) Patch
M lily/include/lily-guile.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/lily-guile.cc View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M lily/lily-parser-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/note-head.cc View 1 2 chunks +22 lines, -17 lines 0 comments Download
M lily/page-turn-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/paper-column-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/program-option-scheme.cc View 2 chunks +47 lines, -44 lines 0 comments Download
M lily/rest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M lily/stem.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M lily/time-signature.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19
Bertrand Bordage
Hi, This is a try to increase performance, especially under Windows (see http://code.google.com/p/lilypond/issues/detail?id=1926). As I ...
7 years, 8 months ago (2011-10-07 09:37:18 UTC) #1
mail_philholmes.net
----- Original Message ----- From: <bordage.bertrand@gmail.com> To: <bordage.bertrand@gmail.com> Cc: <reply@codereview.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Friday, October 07, ...
7 years, 8 months ago (2011-10-07 11:27:59 UTC) #2
Graham Percival
On Fri, Oct 07, 2011 at 12:27:52PM +0100, Phil Holmes wrote: > AFAIK, the only ...
7 years, 8 months ago (2011-10-07 11:52:04 UTC) #3
mail_philholmes.net
----- Original Message ----- From: "Graham Percival" <graham@percival-music.ca> To: "Phil Holmes" <mail@philholmes.net> Cc: <bordage.bertrand@gmail.com>; <lilypond-devel@gnu.org>; ...
7 years, 8 months ago (2011-10-07 12:11:02 UTC) #4
Graham Percival
On Fri, Oct 07, 2011 at 01:10:56PM +0100, Phil Holmes wrote: > I'm up for ...
7 years, 8 months ago (2011-10-07 12:41:06 UTC) #5
mail_philholmes.net
----- Original Message ----- From: "Graham Percival" <graham@percival-music.ca> To: "Phil Holmes" <mail@philholmes.net> Cc: <bordage.bertrand@gmail.com>; <lilypond-devel@gnu.org>; ...
7 years, 8 months ago (2011-10-07 16:25:57 UTC) #6
Graham Percival
On Fri, Oct 07, 2011 at 05:25:54PM +0100, Phil Holmes wrote: > Looks like it's ...
7 years, 8 months ago (2011-10-07 16:52:44 UTC) #7
mail_philholmes.net
----- Original Message ----- From: "Graham Percival" <graham@percival-music.ca> To: "Phil Holmes" <mail@philholmes.net> Cc: <bordage.bertrand@gmail.com>; <lilypond-devel@gnu.org>; ...
7 years, 8 months ago (2011-10-07 17:20:03 UTC) #8
Graham Percival
On Fri, Oct 07, 2011 at 06:20:01PM +0100, Phil Holmes wrote: > Best more official ...
7 years, 8 months ago (2011-10-07 17:29:42 UTC) #9
c_sorensen
On 10/7/11 11:29 AM, "Graham Percival" <graham@percival-music.ca> wrote: > On Fri, Oct 07, 2011 at ...
7 years, 8 months ago (2011-10-07 17:34:24 UTC) #10
wl_gnu.org
>> Looks like it's trying to download >> http://kernel.org/pub/software/scm/git/git-1.6.4.4.tar.gz and >> failing to find it ...
7 years, 8 months ago (2011-10-07 17:38:17 UTC) #11
Keith
http://codereview.appspot.com/5233042/diff/1/lily/note-head.cc File lily/note-head.cc (right): http://codereview.appspot.com/5233042/diff/1/lily/note-head.cc#newcode79 lily/note-head.cc:79: out = fm->find_by_name (idx_either); This performs a second lookup ...
7 years, 8 months ago (2011-10-07 17:56:24 UTC) #12
mail_philholmes.net
----- Original Message ----- From: "Graham Percival" <graham@percival-music.ca> To: "Phil Holmes" <mail@philholmes.net> Cc: <bordage.bertrand@gmail.com>; <lilypond-devel@gnu.org>; ...
7 years, 8 months ago (2011-10-07 18:09:59 UTC) #13
Bertrand Bordage
http://codereview.appspot.com/5233042/diff/1/lily/note-head.cc File lily/note-head.cc (right): http://codereview.appspot.com/5233042/diff/1/lily/note-head.cc#newcode79 lily/note-head.cc:79: out = fm->find_by_name (idx_either); Unfortunately, this doesn't work. If ...
7 years, 8 months ago (2011-10-07 22:00:20 UTC) #14
pkx166h
Passes make and make check throws up no reg tests except graphviz.log: --snip-- @@ -14,9 ...
7 years, 8 months ago (2011-10-08 05:17:32 UTC) #15
Neil Puttock
Hi Betrand, This should be split into two patches: one for the optimization and another ...
7 years, 8 months ago (2011-10-08 16:25:07 UTC) #16
Bertrand Bordage
Thanks Neil, I'll make two commits. Do you want to see them both on codereview? ...
7 years, 8 months ago (2011-10-08 22:46:28 UTC) #17
Keith
looks all good to me.
7 years, 8 months ago (2011-10-10 05:20:15 UTC) #18
Bertrand Bordage
7 years, 8 months ago (2011-10-18 13:01:39 UTC) #19
Pushed as 8adeb99e344bf047b9b3b9b48a9e97e59e8fc4d3 and
71aa438bce0f68b0e8ab8c633b4902c971ede48b.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b