Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

Issue 5183042: Fix a few lilypond-book bugs on windows (Issue 1815). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by Julien Rioux
Modified:
7 years, 7 months ago
Reviewers:
circuitsoft.alex, Reinhold
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix a few lilypond-book bugs on windows (Issue 1815). - book_snippets.py: Replace os.link (purely unix) when it is unavailable by shutil.copyfile. - lilylib.py: Windows command-line arguments don't need escaping. - lilypond-book.py: Use forward slashes within lilypond files.

Patch Set 1 #

Total comments: 4

Patch Set 2 : copy files instead of removing them, still use link when available #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M python/book_snippets.py View 1 2 chunks +8 lines, -1 line 0 comments Download
M python/lilylib.py View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/lilypond-book.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Reinhold
http://codereview.appspot.com/5183042/diff/1/python/book_snippets.py File python/book_snippets.py (right): http://codereview.appspot.com/5183042/diff/1/python/book_snippets.py#newcode643 python/book_snippets.py:643: os.rename (src, dst) Doesn't this REMOVE the src? os.link ...
7 years, 9 months ago (2011-10-04 20:10:43 UTC) #1
Julien Rioux
Of course you know the code better, so please investigate. I did not understand why ...
7 years, 9 months ago (2011-10-04 20:22:28 UTC) #2
circuitsoft.alex_gmail.com
On Tue, Oct 4, 2011 at 3:22 PM, <julien.rioux@gmail.com> wrote: > > ... There are ...
7 years, 9 months ago (2011-10-05 03:17:18 UTC) #3
Julien Rioux
7 years, 9 months ago (2011-10-05 14:17:29 UTC) #4
On Wed, Oct 5, 2011 at 5:17 AM, Alex Austin <circuitsoft.alex@gmail.com> wrote:
> On Tue, Oct 4, 2011 at 3:22 PM, <julien.rioux@gmail.com> wrote:
>>
>> ... There are no hardĀ links that I am aware of.
>
> http://msdn.microsoft.com/en-us/library/windows/desktop/aa365006(v=vs.85).aspx

It is not a restriction of NTFS but of the windows C api and thus
indirectly a restriction for python on windows. Are you aware of some
python 2.4 code that implements it?

Regards,
Julien
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b