Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1945)

Issue 5131046: update SkFontHost for Leopard, Lion, Chromium Skia on Mac (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by caryclark1
Modified:
7 years, 11 months ago
Reviewers:
reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Allow the WebKit client to disable font smoothing on a device. For the caller to override this, a separate API should be added to globally allow this within Skia (future work to do). Chromium reports crashes in CFCharacterSetCreateBitmapRepresentation, which I assume could only happen if CTFontCopyCharSet fails. Leopard ignores the font transformation, so explicitly specify the font size and apply the skew separately. Lion returns fractional values for the character bounds; adjust the width and height until the glyph fully draws. (see http://code.google.com/p/chromium/issues/detail?id=98239 )

Patch Set 1 #

Patch Set 2 : Additionally check for failure from CTFontCopyCharSet. #

Patch Set 3 : add support Leopard, Lion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -4 lines) Patch
M src/ports/SkFontHost_mac_coretext.cpp View 1 2 8 chunks +103 lines, -4 lines 0 comments Download

Messages

Total messages: 1
reed1
8 years ago (2011-10-05 14:35:40 UTC) #1
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b