code review 51000043: cmd/api: ensure GOPATH always points to the correct go.tools

cmd/api: ensure GOPATH always points to the correct go.tools

[brainman, 2014-01-13 01:34:20]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dfc, 2014-01-13 02:20:31]

Is it possible to write the description without a double negative ?


On Mon, Jan 13, 2014 at 12:34 PM, <alex.brainman@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/api: do not assume that GOPATH is not set
>
> Please review this at https://codereview.appspot.com/51000043/
>
> Affected files (+1, -1 lines):
>   M src/cmd/api/run.go
>
>
> Index: src/cmd/api/run.go
> ===================================================================
> --- a/src/cmd/api/run.go
> +++ b/src/cmd/api/run.go
> @@ -46,7 +46,7 @@
>         gopath := prepGoPath()
>
>         cmd := exec.Command("go", "install", "--tags=api_tool", "cmd/api")
> -       cmd.Env = append([]string{"GOPATH=" + gopath},
> filterOut(os.Environ(), "GOARCH")...)
> +       cmd.Env = append(filterOut(os.Environ(), "GOARCH", "GOPATH"),
> "GOPATH="+gopath)
>         out, err := cmd.CombinedOutput()
>         if err != nil {
>                 log.Fatalf("Error installing cmd/api: %v\n%s", err, out)
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[brainman, 2014-01-13 02:21:32]

On 2014/01/13 02:20:31, dfc wrote:
> Is it possible to write the description without a double negative ?
> 

I tried. My brain is not good enough. Please, make a suggestion.

Alex

[dfc, 2014-01-13 03:01:31]

On 2014/01/13 02:21:32, brainman wrote:
> On 2014/01/13 02:20:31, dfc wrote:
> > Is it possible to write the description without a double negative ?
> > 
> 
> I tried. My brain is not good enough. Please, make a suggestion.
> 
> Alex

How about

cmd/api: ensure GOPATH always points to the correct go tool.

[brainman, 2014-01-13 03:18:43]

Hello golang-codereviews@googlegroups.com, dave@cheney.net (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[bradfitz, 2014-01-13 20:36:20]

LGTM

[bradfitz, 2014-01-13 20:37:27]

Does this fix Issue 6922?

[brainman, 2014-01-13 21:21:50]

On 2014/01/13 20:37:27, bradfitz wrote:
> Does this fix Issue 6922?

It does not. I do not know what the problem is. Looks like memory corruption to
me, but I have no evidence. I suggest we use latest version of go.tools. See my
comments at issue 6922.

Alex

[dfc, 2014-01-13 21:26:40]

On 2014/01/13 21:21:50, brainman wrote:
> On 2014/01/13 20:37:27, bradfitz wrote:
> > Does this fix Issue 6922?
> 
> It does not. I do not know what the problem is. Looks like memory corruption
to
> me, but I have no evidence. I suggest we use latest version of go.tools. See
my
> comments at issue 6922.
> 
> Alex

Here is an interesting data point, freebsd/386 just failed with a similar, but
not identical error to win32
http://build.golang.org/log/7cd5f14d69678245f718c9269bab386da26a4418

[brainman, 2014-01-14 05:56:29]

*** Submitted as https://code.google.com/p/go/source/detail?r=05154ae447b6 ***

cmd/api: ensure GOPATH always points to the correct go.tools

R=golang-codereviews, dave, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/51000043