Issue 50660044: code review 50660044: net: fix incorrect internal IPv6 address represenetaion...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 50660044: code review 50660044: net: fix incorrect internal IPv6 address represenetaion... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by mikio

Modified:
10 years, 3 months ago

Reviewers:
r

CC:
golang-codereviews, r

Visibility:
Public.

Description

net: fix incorrect internal IPv6 address representation in test Also fixes a dialgoogle test glitch after issue 6628 fix.

Patch Set 1 : diff -r 21fb28e644a1 https://code.google.com/p/go #

Patch Set 2 : diff -r 0337092aa784 https://code.google.com/p/go #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/net/dialgoogle_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 3 months ago (2014-01-11 03:08:37 UTC) #1

LGTM Please s/represenetaion/representation/ in CL description.

10 years, 3 months ago (2014-01-13 15:31:34 UTC) #2

mikio

10 years, 3 months ago (2014-01-13 22:36:43 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=c93fc4d989ad ***

net: fix incorrect internal IPv6 address representation in test

Also fixes a dialgoogle test glitch after issue 6628 fix.

R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/50660044

Expand All Messages | Collapse All Messages