Add support for network listing api call

Add support for network listing api call

Lists networks using the os-networks extension, which may backend
onto either neutron or nova-network. This should provide a baseline
of support even where the neutron api is not available.

Goose doesn't yet support detecting if a given extension is supported,
that would be nice here as we'll want to know which of neutron,
os-networks, and os-tenant-networks are usable.

https://code.launchpad.net/~gz/goose/list_networks/+merge/201906

(do not edit description out of merge proposal)

[gz, 2014-01-16 10:56:02]

Please take a look.

[dimitern, 2014-01-16 11:35:46]

LGTM with some suggestions.

https://codereview.appspot.com/50630044/diff/1/nova/live_test.go
File nova/live_test.go (right):

https://codereview.appspot.com/50630044/diff/1/nova/live_test.go#newcode518
nova/live_test.go:518: c.Assert(network.Cidr, Not(Equals), "")
Perhaps a bit more restrictive checks for things with known format is in order
here:
c.Check(network.Cidr, Matches, `\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}/\d+`) ?

https://codereview.appspot.com/50630044/diff/1/nova/networks.go
File nova/networks.go (right):

https://codereview.appspot.com/50630044/diff/1/nova/networks.go#newcode14
nova/networks.go:14: apiTenantNetworks = "os-tenant-networks"
Do we use this anywhere or it's just for the future when we can detect what
extensions are supported?

Also, it will be nice to have a doc comment block with links to the openstack
api docs?

https://codereview.appspot.com/50630044/diff/1/testservices/novaservice/servi...
File testservices/novaservice/service.go (right):

https://codereview.appspot.com/50630044/diff/1/testservices/novaservice/servi...
testservices/novaservice/service.go:116: var netId = "1"
or netId := "1"

https://codereview.appspot.com/50630044/diff/1/testservices/novaservice/servi...
File testservices/novaservice/service_http.go (right):

https://codereview.appspot.com/50630044/diff/1/testservices/novaservice/servi...
testservices/novaservice/service_http.go:1006: // TODO(gz): proper handling of
other methods
Usually all testservices handle other methods with some sane error messages
(initially I tested all sorts of requests and methods and added cases to mimic
nova responses), so ideally I'd like to see all the method cases here.

[gz, 2014-01-16 13:03:43]

https://codereview.appspot.com/50630044/diff/1/nova/live_test.go
File nova/live_test.go (right):

https://codereview.appspot.com/50630044/diff/1/nova/live_test.go#newcode518
nova/live_test.go:518: c.Assert(network.Cidr, Not(Equals), "")
On 2014/01/16 11:35:46, dimitern wrote:
> Perhaps a bit more restrictive checks for things with known format is in order
> here:
> c.Check(network.Cidr, Matches, `\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}/\d+`) ?

That seems reasonable (we'll ignore ipv6), will do.

https://codereview.appspot.com/50630044/diff/1/nova/networks.go
File nova/networks.go (right):

https://codereview.appspot.com/50630044/diff/1/nova/networks.go#newcode14
nova/networks.go:14: apiTenantNetworks = "os-tenant-networks"
On 2014/01/16 11:35:46, dimitern wrote:
> Do we use this anywhere or it's just for the future when we can detect what
> extensions are supported?

Not used at present, it's a more recent alternative.

> Also, it will be nice to have a doc comment block with links to the openstack
> api docs?

The openstack docs are annoyingly non-linkable, and the extension stuff is
pretty sketchy, I'll see what I can find.

https://codereview.appspot.com/50630044/diff/1/testservices/novaservice/servi...
File testservices/novaservice/service.go (right):

https://codereview.appspot.com/50630044/diff/1/testservices/novaservice/servi...
testservices/novaservice/service.go:116: var netId = "1"
On 2014/01/16 11:35:46, dimitern wrote:
> or netId := "1"

I should really generate it somehow.

https://codereview.appspot.com/50630044/diff/1/testservices/novaservice/servi...
File testservices/novaservice/service_http.go (right):

https://codereview.appspot.com/50630044/diff/1/testservices/novaservice/servi...
testservices/novaservice/service_http.go:1006: // TODO(gz): proper handling of
other methods
On 2014/01/16 11:35:46, dimitern wrote:
> Usually all testservices handle other methods with some sane error messages
> (initially I tested all sorts of requests and methods and added cases to mimic
> nova responses), so ideally I'd like to see all the method cases here.

Yeah, I'll do some more poking of serverstack to see what the actual behaviour
is like.

[gz, 2014-01-16 14:53:43]

Please take a look.